Page MenuHomePhabricator

Make PHPUnit dataProvider static in ReadingLists tests
Closed, ResolvedPublic

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

  • ApiQueryReadingListEntriesTest with apiQueryProvider
  • ApiQueryReadingListsTest with apiQueryProvider

static and adjust the usages (More infos at T332865).

Initial work was done in d0ee3d4069c29675a8b013df37e9f8a2a708c199

Event Timeline

Change #1142665 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ReadingLists@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1142665

Change #1142665 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1142665