Maniphest T337158

Make PHPUnit dataProvider static in Flow tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 20 2023, 10:13 PM

Tags

Referenced Files

None

Subscribers

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

RevisionFormatterTest with decideContentFormatProvider, decideContentInvalidFormatProvider and setContentFormatInvalidProvider
PagerTest with provideDataMakePagingLink

static and adjust the usages (More infos at T332865).

Initial work was done in 2b47703615174730e5cae98a00fc7a41c3909ebc

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	tests: Make PHPUnit data provider static	mediawiki/extensions/Flow	master	+53 -51

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T255792 Quibble runs core:unit tests twice!
		Stalled		None	T334726 Use return type `never` in Wikibase
		Open		None	T232915 Red-green in PHPUnit code coverage are hard to read
		Open		None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
		Open		None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
		Open		None	T332865 PHPUnit data providers should be simple static functions that return plain data
		Resolved		Umherirrender	T337158 Make PHPUnit dataProvider static in Flow tests

Event Timeline

Umherirrender created this task.May 20 2023, 10:13 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 20 2023, 10:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 20 2023, 10:13 PM

Probably not worth putting much effort into Flow tech debt reduction (see T332022: [Epic] Undeploying StructuredDiscussions (Flow)).

Umherirrender updated the task description. (Show Details)May 30 2023, 7:33 PM

Umherirrender unsubscribed.Jul 12 2023, 8:42 PM

Umherirrender claimed this task.May 7 2025, 7:25 PM

Change #1143173 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1143173

gerritbot added a project: Patch-For-Review.May 7 2025, 7:29 PM

Change #1143173 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1143173

Maintenance_bot removed a project: Patch-For-Review.May 8 2025, 8:30 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 8 2025, 9:00 PM

matmarex closed this task as Resolved.May 8 2025, 9:29 PM