Page MenuHomePhabricator

Make PHPUnit dataProvider static in Flow tests
Open, Needs TriagePublic

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

  • RevisionFormatterTest with decideContentFormatProvider, decideContentInvalidFormatProvider and setContentFormatInvalidProvider
  • PagerTest with provideDataMakePagingLink

static and adjust the usages (More infos at T332865).

Initial work was done in 2b47703615174730e5cae98a00fc7a41c3909ebc