Page MenuHomePhabricator

Make PHPUnit dataProvider static in Math tests
Closed, ResolvedPublic

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

  • MathWikibaseConnectorTest with provideItemSetups
  • PopupTest with provideItemSetups
  • EnWikiFormulaeTest with provideTestCases

static and adjust the usages (More infos at T332865).

Initial work was done in 7a8d5b9dc475b728b681198511b94f8434b31775

Event Timeline

Thank you. What is left to be done?

  • MathWikibaseConnectorTest with provideItemSetups
  • PopupTest with provideItemSetups
  • EnWikiFormulaeTest with provideTestCases

Change 967597 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Make dataProvider in EnWikiFormulaeTest static

https://gerrit.wikimedia.org/r/967597

Change 967594 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Make dataProvider in MathWikibaseConnectorTest static

https://gerrit.wikimedia.org/r/967594

Change 967596 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Make dataProvider in PopupTest static

https://gerrit.wikimedia.org/r/967596

Change 967594 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Make dataProvider in MathWikibaseConnectorTest static

https://gerrit.wikimedia.org/r/967594

Change 967596 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Make dataProvider in PopupTest static

https://gerrit.wikimedia.org/r/967596

Change 967597 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Make dataProvider in EnWikiFormulaeTest static

https://gerrit.wikimedia.org/r/967597

Change #1140299 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Math@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140299

Change #1140299 merged by jenkins-bot:

[mediawiki/extensions/Math@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140299