Make PHPUnit dataProvider static in ProofreadPage tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 20 2023, 11:12 PM

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

FileProviderTest with indexFileProvider, indexFileNotFoundProvider, pageFileProvider and pageFileNotFoundProvider
IndexTemplateStylesTest with indexStylesProvider
QualityStatsBuilderTest with provideStatsForPaginationProviderWithOverride
DatabasePageQualityLevelLookupTest with prefetchQualityLevelForTitlesProvider
Pagination\FilePaginationTest with getPageNumberWithFailureProvider
SimpleFilePaginationTest with getPageNumberWithFailureProvider

static and adjust the usages (More infos at T332865).

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	tests: Make PHPUnit data provider static	mediawiki/extensions/ProofreadPage	master	+202 -193

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T332865 PHPUnit data providers should be simple static functions that return plain data
Resolved	Umherirrender	T337162 Make PHPUnit dataProvider static in ProofreadPage tests

Change #1147838 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ProofreadPage@master] tests: Make PHPUnit data provider static

Change #1147838 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] tests: Make PHPUnit data provider static