Page MenuHomePhabricator
Create Task
Maniphest T337163

Make PHPUnit dataProvider static in CirrusSearch tests
Closed, ResolvedPublic
Actions

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

  • QueryStringRegexParserIntegrationTest with provideRefImplQueries
  • PhraseSuggestFallbackMethodTest with provideTest
  • FetchPhaseConfigBuilderTest with provideNewHighlightFieldWithFactory
  • HighlightedFieldBuilderTest with provideTestFactories
  • QueueingRemediatorTest with provideTestJobIsSent

static and adjust the usages (More infos at T332865).

Initial work was done in c2c3b845cfe91f937ff569e1a617961b9db33450

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
tests: Make PHPUnit data provider static in QueryStringRegexParser testsmediawiki/extensions/CirrusSearchmaster+4 -4
tests: Make PHPUnit data provider staticmediawiki/extensions/CirrusSearchmaster+51 -43
tests: Make PHPUnit data provider staticmediawiki/extensions/CirrusSearchmaster+14 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.May 20 2023, 11:13 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 20 2023, 11:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 20 2023, 11:13 PM
Gehel moved this task from needs triage to watching / waiting on the Discovery-Search board.May 22 2023, 12:54 PM
Umherirrender updated the task description. (Show Details)May 30 2023, 7:32 PM
Umherirrender unsubscribed.Jul 12 2023, 8:42 PM
gerritbot added a comment.May 1 2025, 5:13 AM

Change #1140282 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140282

gerritbot added a project: Patch-For-Review.May 1 2025, 5:13 AM
gerritbot added a comment.May 1 2025, 2:36 PM

Change #1140282 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140282

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).May 1 2025, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 1 2025, 3:30 PM
gerritbot added a comment.May 17 2025, 8:46 PM

Change #1147117 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] tests: Remove REGEN_PARSER_TESTS option in QueryStringRegexParser tests

https://gerrit.wikimedia.org/r/1147117

gerritbot added a project: Patch-For-Review.May 17 2025, 8:46 PM
gerritbot added a comment.May 17 2025, 9:02 PM

Change #1147118 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1147118

Umherirrender claimed this task.May 17 2025, 9:03 PM
gerritbot added a comment.May 19 2025, 9:13 AM

Change #1147118 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1147118

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 19 2025, 10:00 AM
gerritbot added a comment.May 20 2025, 9:46 AM

Change #1147117 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] tests: Make PHPUnit data provider static in QueryStringRegexParser tests

https://gerrit.wikimedia.org/r/1147117

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 20 2025, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 10:30 AM
Umherirrender closed this task as Resolved.May 20 2025, 5:41 PM
Gehel edited projects, added Discovery-Search (2025.05.02 - 2025.05.23); removed Discovery-Search.May 23 2025, 12:13 PM
Gehel moved this task from Incoming to Reported on the Discovery-Search (2025.05.02 - 2025.05.23) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits