Page MenuHomePhabricator
Create Task
Maniphest T337164

Make PHPUnit dataProvider static in FileImporter tests
Closed, ResolvedPublic
Actions

Description

The @dataProvider annotation should be a static function. More information at T332865: PHPUnit data providers should be simple static functions that return plain data. Check and make all data providers in the extension static and adjust the usages.

  • ImportPlanValidatorTest with provideValidate
  • SpecialImportFileIntegrationTest with provideTestData
  • FileRevisionsTest with provideGetLatest
  • TextRevisionsTest with provideLatestTextRevision

Initial work was done in 9c158b710947eb16557ff209e7cd633c1d8f8462

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make all SpecialImportFileIntegrationTest data providers staticmediawiki/extensions/FileImportermaster+20 -29
Migrate SpecialImportFileIntegrationTest away from complex mocksmediawiki/extensions/FileImportermaster+64 -69
Make ImportPlanValidatorTest provider staticmediawiki/extensions/FileImportermaster+17 -33
Remove non-static dataProviders in two testsmediawiki/extensions/FileImportermaster+12 -22
Migrate ImportPlanValidatorTest provider away from ImportPlan mocksmediawiki/extensions/FileImportermaster+13 -13
Migrate ImportPlanValidatorTest away from providing complex mocksmediawiki/extensions/FileImportermaster+46 -71
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.May 20 2023, 11:36 PM
Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.
WMDE-Fisch added a project: WMDE-TechWish-Maintenance.May 21 2023, 10:59 AM
gerritbot added a comment.May 24 2023, 4:19 PM

Change 922896 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Remove non-static dataProviders in two tests

https://gerrit.wikimedia.org/r/922896

gerritbot added a project: Patch-For-Review.May 24 2023, 4:19 PM
gerritbot added a comment.May 24 2023, 4:25 PM

Change 922900 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Migrate ImportPlanValidatorTest away from providing complex mocks

https://gerrit.wikimedia.org/r/922900

gerritbot added a comment.May 24 2023, 4:41 PM

Change 922902 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Migrate ImportPlanValidatorTest provider away from ImportPlan mocks

https://gerrit.wikimedia.org/r/922902

gerritbot added a comment.May 24 2023, 4:59 PM

Change 922906 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Make ImportPlanValidatorTest provider static

https://gerrit.wikimedia.org/r/922906

gerritbot added a comment.May 25 2023, 11:04 AM

Change 922900 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Migrate ImportPlanValidatorTest away from providing complex mocks

https://gerrit.wikimedia.org/r/922900

gerritbot added a comment.May 25 2023, 11:06 AM

Change 922902 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Migrate ImportPlanValidatorTest provider away from ImportPlan mocks

https://gerrit.wikimedia.org/r/922902

gerritbot added a comment.May 25 2023, 11:06 AM

Change 922906 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Make ImportPlanValidatorTest provider static

https://gerrit.wikimedia.org/r/922906

gerritbot added a comment.May 25 2023, 11:06 AM

Change 922896 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Remove non-static dataProviders in two tests

https://gerrit.wikimedia.org/r/922896

Maintenance_bot removed a project: Patch-For-Review.May 25 2023, 11:10 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 25 2023, 12:00 PM
thiemowmde updated the task description. (Show Details)May 25 2023, 2:03 PM
thiemowmde added subscribers: thiemowmde, WMDE-Fisch.
Umherirrender updated the task description. (Show Details)May 30 2023, 7:32 PM
Umherirrender unsubscribed.Jul 12 2023, 8:42 PM
gerritbot added a comment.Jul 17 2023, 9:14 AM

Change 938804 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Migrate SpecialImportFileIntegrationTest away from complex mocks

https://gerrit.wikimedia.org/r/938804

gerritbot added a project: Patch-For-Review.Jul 17 2023, 9:14 AM
gerritbot added a comment.Jul 17 2023, 9:25 AM

Change 938806 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Make all SpecialImportFileIntegrationTest data providers static

https://gerrit.wikimedia.org/r/938806

thiemowmde claimed this task.Jul 17 2023, 9:26 AM
thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.
thiemowmde added a project: WMDE-TechWish-Maintenance-2023.
thiemowmde moved this task from Backlog to Review on the WMDE-TechWish-Maintenance-2023 board.
gerritbot added a comment.Jul 17 2023, 10:49 AM

Change 938804 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Migrate SpecialImportFileIntegrationTest away from complex mocks

https://gerrit.wikimedia.org/r/938804

gerritbot added a comment.Jul 17 2023, 10:49 AM

Change 938806 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Make all SpecialImportFileIntegrationTest data providers static

https://gerrit.wikimedia.org/r/938806

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).Jul 17 2023, 11:00 AM
WMDE-Fisch removed thiemowmde as the assignee of this task.Jul 17 2023, 11:06 AM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.
Maintenance_bot removed a project: Patch-For-Review.Jul 17 2023, 11:10 AM
WMDE-Fisch closed this task as Resolved.Jul 18 2023, 8:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits