Page MenuHomePhabricator

Surface is not properly focused after closing a dialog
Closed, DuplicatePublic

Description

  • Open an dialog (e.g. help dialog with ctrl+?) then close it.
  • Try to move your cursor with arrow keys

Focus should be restored to the surface (on desktop) but it isn't.

Event Timeline

It looks like the window manager is stealing focus back. We have a call to surface.getView().activate() but it probably needs to be deferred, or we can try using $returnFocusTo on the WindowManager, or work out why the window manager is stealing focus.