Page MenuHomePhabricator

[S] Temporary Accounts on iOS: Edit history related changes
Closed, ResolvedPublic1 Estimated Story Points

Description

Summary of updates

Outlined below are proposed updates to the iOS edit history view to reflect proposed changes on desktop web related to IP masking work. Icons used in these designs come from T335694 and are subject to change based on updates from AHT.

Relevant links

Proposed designs

Edit history
image.png (1×750 px, 110 KB)
Design details

In edit count area:

  • 'anon edits' string replaced with 'unregistered'
  • 'anonymous' icon replaced with new 'temporary account' icon
  • 'user edits' string replaced with 'logged-in'
  • 'bot edits' string replaced with 'bot'

In the list of edits and compare area:

  • For historical edits made by IP addresses: NO CHANGES
  • For new edits made by unregistered / temporary accounts: update icon from 'anonymous' icon to new 'temporary account' icon and show temp account name NOT IP address

Related affected screens

  • Updates to icons for unregistered/temp accounts should also appear in the diff view / on watchlists and anywhere else an unregistered/temp account user is referenced throughout the app

Assets

IP masking temp account icon
image.png (220×220 px, 4 KB)
from https://phabricator.wikimedia.org/T335694

Engineering Notes

  1. For the unregistered counts data, please aggregate the counts from https://{lang}.wikipedia.org/w/rest.php/v1/page/{title}/history/counts/anonymous and https://{lang}.wikipedia.org/w/rest.php/v1/page/{title}/history/counts/temporary. Currently those counts are only the number from the anonymous endpoint.
  2. (Unrelated bug, let's fix while we're here) The "user edits" count section (to be renamed to "logged-in"), is currently powered by this endpoint: https://test.wikipedia.org/w/rest.php/v1/page/IOS/history/counts/userEdits. However, that is failing on Test Wiki. We should check and see if we have the incorrect endpoint naming here.
  3. The revision cell data is currently powered by the MediaWiki revisions endpoint (example). To determine if a revision was made by a temporary user, the object will have this temp = "" key:
{
            "revid": 620790,
            "parentid": 620788,
            "user": "~2024-7809",
            "temp": "",
            "timestamp": "2024-10-24T16:29:15Z",
            "size": 4592,
            "parsedcomment": "Fixed typo"
}

And anonymous edits look like this:

{
            "revid": 588205,
            "parentid": 588171,
            "user": "198.17.32.214",
            "anon": "",
            "timestamp": "2024-02-06T22:18:00Z",
            "size": 2162,
            "parsedcomment": ""
}

We will need to deserialize this new temp: "" key and check if it exists before using the correct icon. Continuing to display the user name value will still work as it did when displaying the IP address, since it's now populated with the temp account name.

QA Notes

Experimental Build 238

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
LGoto triaged this task as Low priority.May 23 2023, 4:29 PM
HNordeenWMF renamed this task from IP Masking on iOS: Edit history related changes to Temporary Accounts on iOS: Edit history related changes.Apr 2 2024, 4:04 PM
Tsevener renamed this task from Temporary Accounts on iOS: Edit history related changes to [S] Temporary Accounts on iOS: Edit history related changes.Sep 5 2024, 5:23 PM

@cmadeo

Questions from eng sync:

  • Are we just changing the icon or are we also supposed to fully obscure the temp account name (replace all with **)
  • For the counts sections, are we just changing copy here or is the actual underlying data expected to change? We are pulling anon counts from this endpoint - https://test.wikipedia.org/w/rest.php/v1/page/Iodine/history/counts/anonymous - I don't think we have a separate endpoint for temporary account counts.

Hi @Tsevener great questions

Are we just changing the icon or are we also supposed to fully obscure the temp account name (replace all with **)

Apologies, we didn't know what form the temp account names would have so I used ** as a placeholder -- we should show the temp account names unobscured.

For the counts sections, are we just changing copy here or is the actual underlying data expected to change? We are pulling anon counts from this endpoint - https://test.wikipedia.org/w/rest.php/v1/page/Iodine/history/counts/anonymous - I don't think we have a separate endpoint for temporary account counts.

For the round-up we can replace the 'anon' icon with the 'unregistered user' icon and call the whole group 'unregistered'.

image.png (1×750 px, 139 KB)

But edits in the list of difs that were made by IPs (eg. pre-temp accounts) should be reflected as such as this is how they will be handled on web.

image.png (1×750 px, 127 KB)

For the round-up we can replace the 'anon' icon with the 'unregistered user' icon and call the whole group 'unregistered'.

Ok, I have discussed with @Dbrant and it sounds like there is a new temporary counts endpoint:

https://test.wikipedia.org/w/rest.php/v1/page/Earth/history/counts/temporary

So we should be able to combine the anonymous and temporary counts and display them in the "unregistered" box. Sound good @cmadeo?

HNordeenWMF raised the priority of this task from Low to Medium.Dec 19 2024, 10:21 PM
Seddon set the point value for this task to 1.Jan 8 2025, 7:03 PM

System nav bar changes quite a bit on this screen, so moving to blocked until that is merged so we don't have a bunch of merge conflicts.

Build will be in Experimental 7.7.0 (216) for design review.

HNordeenWMF lowered the priority of this task from Medium to Low.Feb 6 2025, 8:45 PM

This is merged into a feature branch (temp-accounts). We will move to QA once the feature is complete and the branch is merged into main.

@Tsevener does "unregistered edits" at the top currently total both Temporary account edits & previous IP edits?

Also These copy edits didn't fully happen and would be nice-to-have (I'm guessing design suggested removing "edits" to fit the longer terms in for other languages)

  • 'anon edits' string replaced with 'unregistered'
  • ✅ 'user edits' string replaced with 'logged-in'
  • 'bot edits' string replaced with 'bot'

@HNordeenWMF

does "unregistered edits" at the top currently total both Temporary account edits & previous IP edits?

Yep it does! For example the Test Wiki IOS page shows 89:

Screenshot 2025-04-18 at 9.54.54 AM.png (1×559 px, 261 KB)

Which is an aggregate of anonymous and temporary endpoints:

https://test.wikipedia.org/w/rest.php/v1/page/IOS/history/counts/anonymous
https://test.wikipedia.org/w/rest.php/v1/page/IOS/history/counts/temporary

Screenshot above is the copy change PR I just put up, let me know if that looks good to you.

@HNordeenWMF

does "unregistered edits" at the top currently total both Temporary account edits & previous IP edits?

Yep it does! For example the Test Wiki IOS page shows 89:

Screenshot 2025-04-18 at 9.54.54 AM.png (1×559 px, 261 KB)

Which is an aggregate of anonymous and temporary endpoints:

https://test.wikipedia.org/w/rest.php/v1/page/IOS/history/counts/anonymous
https://test.wikipedia.org/w/rest.php/v1/page/IOS/history/counts/temporary

Hello, I've just had a look at this task from a Trust & Safety Product perspective. Can we change the icon that displays above the unregistered aggregate number? Displaying the temporary user icon is confusing as it's actually a combination of temp user and IP edits. I suggest we change UserTemporary to UserAnonymous to avoid confusion, as currently it implies '89' is number of temp user edits.

cc @scblr

Sorry to step in here, but I've noticed that the hr below the stats has gone missing which I believe is not up to design spec unless @scblr removed this line in another spec for this page (apologies if that is the case, although I do think the information architecture is clearer with the stats encased in a 'table')

The original spec for this ticket (see description) and the old design of this page had a hr above and below the stats.

Hey @GOlson-WMF 👋

1. Can you update the iconography here...

CleanShot 2025-04-28 at 13.28.46.png (1×559 px, 265 KB)

... to use this one:

CleanShot 2025-04-28 at 13.30.33@2x.png (2×3 px, 400 KB)

We already use it for anonymous edit in the app.

2. And to @cmadeo’s point...

CleanShot 2025-04-28 at 13.37.47.png (1×559 px, 272 KB)

(...) I've noticed that the hr below the stats has gone missing which I believe is not up to design spec (...)

...add a separator line below the stats:

Thanks!