Revisit the type of Z516's 'argument' key
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DMartin-WMF
	May 24 2023, 12:54 AM

Description

Concerns have been raised about Z18 as the type of Z516's 'argument' key; in particular, an instance of Z18 can be resolved, whereas we wouldn't want resolution to happen inside an error object.

Based on comments in this merge request and also a recent voice conversation, Z39 appears to be a good candidate for the type of this key. Z516 is only used in a few places, and changing the type of this key from Z18 to Z39 should require only a smallish effort. Z516 has no uses in WikiLambda and none in function-evaluator.

Note that Z511 and Z526 both use keys of type Z39 to refer to other arbitrary keys, similarly to how Z516's 'argument' key is used.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

All tests involving Z516 should continue to work (after being modified appropriately).

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update function-schemata sub-module to HEAD (9abc7c2)	mediawiki/extensions/WikiLambda	master	+1 -1

Customize query in gerrit

Related Changes in GitLab:

Title	Reference	Author	Source Branch	Dest Branch
Update function-schemata sub-module to HEAD (9abc7c2)	repos/abstract-wiki/wikifunctions/wikilambda-cli!8	jforrester	sync-function-schemata	main
Update function-schemata sub-module to HEAD (9abc7c2)	repos/abstract-wiki/wikifunctions/function-evaluator!17	jforrester	sync-function-schemata	main
Update function-schemata sub-module to HEAD (9abc7c2)	repos/abstract-wiki/wikifunctions/function-orchestrator!22	jforrester	sync-function-schemata	main
Change type of Z516K1 from Z18 to Z39	repos/abstract-wiki/wikifunctions/function-schemata!10	dmartin	T337354	main

Customize query in GitLab

Related Objects
Search...

Status	Assigned	Task
Resolved	DMartin-WMF	T321113 Audit and update creation and manipulation of errors in the orchestrator and evaluator
Resolved	DMartin-WMF	T321114 Don't create generic errors in the orchestrator, but specific custom ones
Resolved	DMartin-WMF	T321115 Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones
Resolved	DMartin-WMF	T337354 Revisit the type of Z516's 'argument' key