Page MenuHomePhabricator

deployment-charts CI should allow opting out of default fixture injections
Closed, ResolvedPublic

Description

Some helm charts are now published with values.schema.json - a json schema to validate the provided values - case in point, the opentelemetry-collector chart that @RLazarus was trying to import in our repository.

Given this chart has "additionalProperties": false, our CI adding the listeners proxy fixture to tests for every chart/deployment generates an error.

I would suggest that for now we can look if there is a .no-global-fixtures file and don't inject the global fixtures.

Event Timeline

Joe changed the task status from Open to In Progress.May 24 2023, 4:54 AM
Joe claimed this task.
Joe triaged this task as High priority.
Joe moved this task from Incoming 🐫 to Doing 😎 on the serviceops-deprecated board.

Change 922793 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/deployment-charts@master] Add the possibility to override CI settings using a .fixturesctl.yaml files

https://gerrit.wikimedia.org/r/922793

Change 922793 merged by Giuseppe Lavagetto:

[operations/deployment-charts@master] Add the possibility to override CI settings using a .fixturesctl.yaml files

https://gerrit.wikimedia.org/r/922793