Page MenuHomePhabricator
Create Task
Maniphest T337405

Refactor envoy.filters.http.router and envoy.filters.listener.tls_inspector
Closed, ResolvedPublic
Actions

Description

v1.22.0#minor-behavior-changes

  • config: type URL is used to lookup extensions regardless of the name field. This may cause problems for empty filter configurations or mis-matched protobuf as the typed configurations. This behavioral change can be temporarily reverted by setting runtime guard envoy.reloadable_features.no_extension_lookup_by_name to false.

This makes out current configs invalid for envoy >=1.22 as we need to explicitly set the type URL.

Details

SubjectRepoBranchLines +/-
envoyproxy: Add type URL to http and listener filtersoperations/puppetproduction+18 -2
Update all charts to mesh.configuration 1.3.1operations/deployment-chartsmaster+890 -15 K
Update mathoid to mesh.configuration 1.3.1operations/deployment-chartsmaster+27 -10
mesh.configuration: Do not require charts to define .Values.mesh.adminoperations/deployment-chartsmaster+7 -1
mesh.configuration: Add type URL to http and listener filtersoperations/deployment-chartsmaster+8 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

JMeybohm created this task.May 24 2023, 3:16 PM
JMeybohm mentioned this in T300324: Upgrade Envoy to supported version.May 24 2023, 3:23 PM
Maintenance_bot added a project: SRE.May 24 2023, 3:29 PM
gerritbot added a comment.May 25 2023, 10:54 AM

Change 923304 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] mesh.configuration: Add type URL to http and listener filters

https://gerrit.wikimedia.org/r/923304

gerritbot added a project: Patch-For-Review.May 25 2023, 10:54 AM
gerritbot added a comment.Jun 26 2023, 2:36 PM

Change 933112 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/puppet@production] envoyproxy: Add type URL to http and listener filters

https://gerrit.wikimedia.org/r/933112

gerritbot added a comment.Jun 26 2023, 3:54 PM

Change 923304 merged by jenkins-bot:

[operations/deployment-charts@master] mesh.configuration: Add type URL to http and listener filters

https://gerrit.wikimedia.org/r/923304

gerritbot added a comment.Jun 27 2023, 9:07 AM

Change 933391 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] mesh.configuration: Do not require charts to define .Values.mesh.admin

https://gerrit.wikimedia.org/r/933391

gerritbot added a comment.Jun 27 2023, 9:08 AM

Change 933392 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] Update all charts to mesh.configuration 1.3.1

https://gerrit.wikimedia.org/r/933392

gerritbot added a comment.Jun 27 2023, 10:10 AM

Change 933403 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] Update mathoid to mesh.configuration 1.3.1

https://gerrit.wikimedia.org/r/933403

gerritbot added a comment.Jun 27 2023, 10:12 AM

Change 933391 merged by jenkins-bot:

[operations/deployment-charts@master] mesh.configuration: Do not require charts to define .Values.mesh.admin

https://gerrit.wikimedia.org/r/933391

gerritbot added a comment.Jun 27 2023, 10:13 AM

Change 933403 merged by jenkins-bot:

[operations/deployment-charts@master] Update mathoid to mesh.configuration 1.3.1

https://gerrit.wikimedia.org/r/933403

gerritbot added a comment.Jun 28 2023, 10:40 AM

Change 933392 merged by jenkins-bot:

[operations/deployment-charts@master] Update all charts to mesh.configuration 1.3.1

https://gerrit.wikimedia.org/r/933392

gerritbot added a comment.Jun 28 2023, 12:14 PM

Change 933112 merged by JMeybohm:

[operations/puppet@production] envoyproxy: Add type URL to http and listener filters

https://gerrit.wikimedia.org/r/933112

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2023, 12:30 PM
JMeybohm closed this task as Resolved.Jun 28 2023, 1:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL