Page MenuHomePhabricator
Create Task
Maniphest T337425

Re-implement post-merge publication of code coverage for Wikifunctions's repos on GitLab
Closed, ResolvedPublic
Actions

Description

We moved our code from gerrit to GitLab for four repos, and in so doing lost our code coverage reports. It'd be great to get these back.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630operations/deployment-chartsmaster+2 -2
function-*: Update links for source and coverage reportsintegration/docrootmaster+6 -6
Update function-schemata sub-module to HEAD (9abc7c2)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
build: Publish test coverage report when merging into the default branchrepos/abstract-wiki/wikifunctions/wikilambda-cli!11jforresterT337425-coveragemain
build: Publish test coverage report when merging into the default branchrepos/abstract-wiki/wikifunctions/wikilambda-cli!9jforrestergitlab-coverage-publicationmain
Update function-schemata sub-module to HEAD (9abc7c2)repos/abstract-wiki/wikifunctions/wikilambda-cli!8jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (9abc7c2)repos/abstract-wiki/wikifunctions/function-evaluator!17jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (9abc7c2)repos/abstract-wiki/wikifunctions/function-orchestrator!22jforrestersync-function-schematamain
build: Publish test coverage report when merging into the default branchrepos/abstract-wiki/wikifunctions/function-evaluator!16jforrestergitlab-coverage-publicationmain
build: Publish test coverage report when merging into the default branchrepos/abstract-wiki/wikifunctions/function-orchestrator!18jforrestergitlab-coverage-publicationmain
Publish test coverage report when merging into the default branchrepos/abstract-wiki/wikifunctions/function-schemata!9jforresterreview/dancy/publish-coverage-reportmain
Customize query in GitLab

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.May 24 2023, 7:03 PM
Jdforrester-WMF added a subtask: T336168: Provide mechanism to publish to doc.wikimedia.org from GitLab CI.

Note that this is blocked by work currently being done by the RelEng team to make this possible.

dancy subscribed.May 24 2023, 7:24 PM
In T337425#8878087, @Jdforrester-WMF wrote:

Note that this is blocked by work currently being done by the RelEng team to make this possible.

https://gitlab.wikimedia.org/repos/releng/docpub is ready to be used now. Setup instructions are in the README.md.

Jdforrester-WMF added a comment.May 24 2023, 7:29 PM
In T337425#8878155, @dancy wrote:
In T337425#8878087, @Jdforrester-WMF wrote:

Note that this is blocked by work currently being done by the RelEng team to make this possible.

https://gitlab.wikimedia.org/repos/releng/docpub is ready to be used now. Setup instructions are in the README.md.

I was waiting for someone else to go first so I could steal their code; the scap example is rather involved. ;-)

dancy added a comment.May 24 2023, 8:20 PM
In T337425#8878166, @Jdforrester-WMF wrote:

I was waiting for someone else to go first so I could steal their code; the scap example is rather involved. ;-)

Gotcha. I'll set something up for you.

dancy added a comment.May 24 2023, 8:37 PM

Have a look at https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/commit/ddec7fca48779bec836223d187e7dc248f7b3081

dancy added a comment.May 24 2023, 9:51 PM
In T337425#8878337, @dancy wrote:

Have a look at https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/commit/ddec7fca48779bec836223d187e7dc248f7b3081

Actually, don't look at that yet. :-) More is needed.

dancy added a subscriber: jnuche.May 24 2023, 10:46 PM

@Jdforrester-WMF @jnuche:
function-evaluator's Zuul CI published its coverage report to https://doc.wikimedia.org/cover/mediawiki-services-function-evaluator/. The mediawiki-services-function-evaluator name was computed by https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/refs/heads/master/zuul/parameter_functions.py#978 based on the Gerrit repository name, which was mediawiki/services/function-evaluator. Now function-evaluator is at https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator and the docpub stuff currently only has the ability to publish to https://doc.wikimedia.org/abstract-wiki/wikifunctions/function-evaluator. We'll need to extend it to support writing to cover/$CI_PROJECT_PATH_WITHOUT_REPOS_PREFIX too. James, is it okay if the coverage URL becomes https://doc.wikimedia.org/cover/abstract-wiki/wikifunctions/function-evaluator?

jnuche added a comment.May 25 2023, 9:36 AM

docpub can now publish test coverage reports under https://doc.wikimedia.org/cover by specifying COVERAGE: 'true' in the publishing job. I've updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/commit/57a1a0c207a04fd3f641cf77aff0cd8598b85167 to reflect the change.

Final URL right now will be: https://doc.wikimedia.org/cover/abstract-wiki/wikifunctions/function-evaluator. But we can add some flattening/processing of the URL as it was done before for gerrit if we think there's value in that.

jnuche closed subtask T336168: Provide mechanism to publish to doc.wikimedia.org from GitLab CI as Resolved.May 25 2023, 12:01 PM
Jdforrester-WMF added a comment.May 25 2023, 4:29 PM
In T337425#8878561, @dancy wrote:

@Jdforrester-WMF @jnuche:
function-evaluator's Zuul CI published its coverage report to https://doc.wikimedia.org/cover/mediawiki-services-function-evaluator/. The mediawiki-services-function-evaluator name was computed by https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/refs/heads/master/zuul/parameter_functions.py#978 based on the Gerrit repository name, which was mediawiki/services/function-evaluator. Now function-evaluator is at https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator and the docpub stuff currently only has the ability to publish to https://doc.wikimedia.org/abstract-wiki/wikifunctions/function-evaluator. We'll need to extend it to support writing to cover/$CI_PROJECT_PATH_WITHOUT_REPOS_PREFIX too. James, is it okay if the coverage URL becomes https://doc.wikimedia.org/cover/abstract-wiki/wikifunctions/function-evaluator?

Yeah, that's fine, as long as they're published I'm happy to tweak the incoming URLs etc..

In T337425#8879377, @jnuche wrote:

docpub can now publish test coverage reports under https://doc.wikimedia.org/cover by specifying COVERAGE: 'true' in the publishing job. I've updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/commit/57a1a0c207a04fd3f641cf77aff0cd8598b85167 to reflect the change.

Final URL right now will be: https://doc.wikimedia.org/cover/abstract-wiki/wikifunctions/function-evaluator. But we can add some flattening/processing of the URL as it was done before for gerrit if we think there's value in that.

This is great, thank you!

CodeReviewBot added a comment.May 25 2023, 4:31 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/9

Publish test coverage report when merging into the default branch

CodeReviewBot added a project: Patch-For-Review.May 25 2023, 4:31 PM
Jdforrester-WMF renamed this task from Re-implement post-merge publication of code coverage and code documentation for Wikifunctions repos on GitLab to Re-implement post-merge publication of code coverage for Wikifunctions's repos on GitLab.May 25 2023, 4:33 PM
Jdforrester-WMF updated the task description. (Show Details)
CodeReviewBot added a comment.May 25 2023, 4:39 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/9

Publish test coverage report when merging into the default branch

Jdforrester-WMF updated the task description. (Show Details)May 25 2023, 4:41 PM
CodeReviewBot added a comment.May 25 2023, 4:53 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/18

build: Publish test coverage report when merging into the default branch

gerritbot added a comment.May 25 2023, 4:59 PM

Change 923394 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/docroot@master] function-*: Update links for source and coverage reports

https://gerrit.wikimedia.org/r/923394

CodeReviewBot added a comment.May 25 2023, 5:15 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/16

Draft: build: Publish test coverage report when merging into the default branch

Jdforrester-WMF claimed this task.May 25 2023, 5:17 PM
Jdforrester-WMF triaged this task as High priority.May 25 2023, 6:04 PM
hashar reopened subtask T336168: Provide mechanism to publish to doc.wikimedia.org from GitLab CI as Open.May 26 2023, 1:12 PM
CodeReviewBot added a comment.May 26 2023, 2:50 PM

kindrobot merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/18

build: Publish test coverage report when merging into the default branch

gerritbot added a comment.May 30 2023, 8:12 PM

Change 924598 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (9abc7c2)

https://gerrit.wikimedia.org/r/924598

CodeReviewBot added a comment.May 30 2023, 8:12 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/22

Update function-schemata sub-module to HEAD (9abc7c2)

CodeReviewBot added a comment.May 30 2023, 8:13 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/17

Update function-schemata sub-module to HEAD (9abc7c2)

CodeReviewBot added a comment.May 30 2023, 8:13 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/8

Update function-schemata sub-module to HEAD (9abc7c2)

CodeReviewBot added a comment.May 30 2023, 11:27 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/22

Update function-schemata sub-module to HEAD (9abc7c2)

CodeReviewBot added a comment.May 30 2023, 11:28 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/17

Update function-schemata sub-module to HEAD (9abc7c2)

CodeReviewBot added a comment.May 30 2023, 11:28 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/8

Update function-schemata sub-module to HEAD (9abc7c2)

gerritbot added a comment.May 30 2023, 11:33 PM

Change 924598 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (9abc7c2)

https://gerrit.wikimedia.org/r/924598

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 31 2023, 1:00 AM
jnuche closed subtask T336168: Provide mechanism to publish to doc.wikimedia.org from GitLab CI as Resolved.May 31 2023, 9:20 AM
Jdforrester-WMF updated the task description. (Show Details)May 31 2023, 3:17 PM
CodeReviewBot added a comment.May 31 2023, 3:32 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/9

build: Publish test coverage report when merging into the default branch

jnuche added a comment.Jun 1 2023, 3:43 PM

Just saw a few links here that I thought would probably make sense to update as part of this task.

Jdforrester-WMF added a comment.Jun 1 2023, 4:00 PM
In T337425#8896115, @jnuche wrote:

Just saw a few links here that I thought would probably make sense to update as part of this task.

Yup, that's https://gerrit.wikimedia.org/r/c/integration/docroot/+/923394/ but I was waiting on the evaluator links going live before deploying.

jnuche added a comment.Jun 1 2023, 4:07 PM

Oh, totally missed the automated comment above. Neat!

Legoktm reopened subtask T336168: Provide mechanism to publish to doc.wikimedia.org from GitLab CI as Open.Jun 2 2023, 6:52 AM
Jdforrester-WMF moved this task from To Triage to To triage: Un-phased work on the Abstract Wikipedia team board.Jun 2 2023, 7:29 PM
gerritbot added a comment.Jun 5 2023, 10:54 PM

Change 923394 merged by jenkins-bot:

[integration/docroot@master] function-*: Update links for source and coverage reports

https://gerrit.wikimedia.org/r/923394

Stashbot added a comment.Jun 5 2023, 10:55 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-05T22:55:19Z] <jforrester@deploy1002> Started deploy [integration/docroot@8255d99]: I6c7575 for T337425

Stashbot added a comment.Jun 5 2023, 10:55 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-05T22:55:33Z] <jforrester@deploy1002> Finished deploy [integration/docroot@8255d99]: I6c7575 for T337425 (duration: 00m 13s)

jnuche closed subtask T336168: Provide mechanism to publish to doc.wikimedia.org from GitLab CI as Resolved.Jun 28 2023, 1:16 PM
CodeReviewBot added a comment.Jul 12 2023, 2:47 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/11

build: Publish test coverage report when merging into the default branch

CodeReviewBot added a comment.Jul 12 2023, 2:47 PM

jforrester closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/9

build: Publish test coverage report when merging into the default branch

Jdforrester-WMF updated the task description. (Show Details)Jul 12 2023, 3:06 PM
CodeReviewBot added a comment.Jul 19 2023, 8:36 PM

kindrobot merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/11

build: Publish test coverage report when merging into the default branch

Jdforrester-WMF changed the task status from Open to In Progress.Oct 26 2023, 4:46 PM
Jdforrester-WMF moved this task from To triage: Un-phased work to In Progress on the Abstract Wikipedia team board.
Jdforrester-WMF lowered the priority of this task from High to Low.Oct 26 2023, 4:56 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 9 2024, 4:42 PM
CodeReviewBot added a comment.Jan 9 2024, 7:42 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/16

build: Publish test coverage report when merging into the default branch

Jdforrester-WMF removed a project: Patch-For-Review.Jan 9 2024, 7:49 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task from In Progress to Verify in production on the Abstract Wikipedia team board.
Jdforrester-WMF closed this task as Resolved.Jan 11 2024, 9:09 PM
gerritbot added a comment.Jan 22 2024, 6:48 PM

Change 992227 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630

https://gerrit.wikimedia.org/r/992227

gerritbot added a project: Patch-For-Review.Jan 22 2024, 6:48 PM
gerritbot added a comment.Jan 22 2024, 7:53 PM

Change 992227 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630

https://gerrit.wikimedia.org/r/992227

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2024, 8:32 PM
DMartin-WMF mentioned this in rMSFE3dc364aeca75: Update function-schemata sub-module to HEAD (9abc7c2).Oct 3 2025, 9:37 AM
Jdforrester-WMF mentioned this in rMSFEaab27f1612f7: build: Publish test coverage report when merging into the default branch.Oct 3 2025, 9:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits