Maniphest T337428

Device Analytics: change metrics route to /metrics
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	BPirkle
	May 24 2023, 7:30 PM

Tags

Referenced Files

None

Subscribers

EChukwukere-WMF

Description

tl;dr: switch the Device Analytics metrics endpoint from /admin/metrics to /metrics

Details:

Our metrics and dashboarding infrastructure needs a consistent endpoint from which to pull metrics from each service. Per Slack discussion, this should be /metrics.

Also per that discussion, these metrics do not need to be publicly accessible. That means it is okay that all the various AQS 2.0 services expose metrics information (only) under /metrics, rather than distinct endpoints like (for example) /metrics/device-analytics, /metrics/page-analytics, etc. Our metrics infrastructure will make calls to the /metrics endpoint for each service using a distinct internal service name and port number, so disambiguation is not an issue.

Device Analytics currently exposes metrics under the endpoint:
/admin/metrics
Switch this to:
/metrics

Details

	Subject	Repo	Branch	Lines +/-
	Change metrics path to /metrics, per convention	generated-data-platform/aqs/device-analytics	main	+54 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T324931 Clean up open RESTBase related tickets
		In Progress		None	T262315 <CORE TECHNOLOGY> API Migration & RESTbase Sunset
		In Progress		• DAbad	T263489 AQS 2.0
		Resolved		SGupta-WMF	T288298 AQS 2.0: Device Analytics service
		Resolved		SGupta-WMF	T337428 Device Analytics: change metrics route to /metrics

Event Timeline

BPirkle created this task.May 24 2023, 7:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2023, 7:30 PM

BPirkle moved this task from Next Up to In Progress on the AQS2.0 (Sprint 10) board.May 24 2023, 7:31 PM

Change 922533 had a related patch set uploaded (by BPirkle; author: BPirkle):

[generated-data-platform/aqs/device-analytics@main] Change metrics path to /metrics, per convention

https://gerrit.wikimedia.org/r/922533

gerritbot added a project: Patch-For-Review.May 24 2023, 7:48 PM

BPirkle reassigned this task from BPirkle to SGupta-WMF.May 24 2023, 7:50 PM

BPirkle triaged this task as Medium priority.

BPirkle moved this task from In Progress to Ready for Code Review/ Ready for Tech input on the AQS2.0 (Sprint 10) board.

SGupta-WMF reassigned this task from SGupta-WMF to Emeka-okechukwu.May 29 2023, 9:01 AM

SGupta-WMF reassigned this task from Emeka-okechukwu to EChukwukere-WMF.

SGupta-WMF moved this task from Ready for Code Review/ Ready for Tech input to In code Review/ Tech Input on the AQS2.0 (Sprint 10) board.

SGupta-WMF moved this task from In code Review/ Tech Input to Ready for Testing on the AQS2.0 (Sprint 10) board.

SGupta-WMF added a subscriber: Emeka-okechukwu.

Change 922533 merged by jenkins-bot:

[generated-data-platform/aqs/device-analytics@main] Change metrics path to /metrics, per convention

https://gerrit.wikimedia.org/r/922533

Maintenance_bot removed a project: Patch-For-Review.May 29 2023, 9:10 AM

BPirkle removed a subscriber: Emeka-okechukwu.May 29 2023, 7:52 PM

SGupta-WMF added a parent task: T288298: AQS 2.0: Device Analytics service.Jun 5 2023, 5:19 AM

Metrics verified .
Results :-

Metrics available on new updated path /metrics , and getting reasonable data

SGupta-WMF claimed this task.Jun 5 2023, 6:16 AM

SGupta-WMF moved this task from Ready for Testing to Sign off on the AQS2.0 (Sprint 10) board.

SGupta-WMF added a subscriber: EChukwukere-WMF.

BPirkle moved this task from Sign off to Done on the AQS2.0 (Sprint 10) board.Jun 6 2023, 7:05 PM

JArguello-WMF closed this task as Resolved.Jun 9 2023, 2:45 PM