OOUI dialogs with tabs can't be interacted with (except the last tab), e.g. VE image dialog
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	May 25 2023, 7:31 PM

Description

OOUI dialogs with tabs can't be interacted with (except the last tab), e.g. VE image dialog. Spotted by @Whatamidoing-WMF.

You can't click any buttons or select text.

This only affects browsers that support hidden="until-found" (which allows the browser's Ctrl+F search to find text in hidden tabs and switch to them), which is basically only recent versions of Chrome: https://caniuse.com/mdn-html_global_attributes_hidden_until-found_value

Examples:

"Indexed dialog (tab navigation)" on https://doc.wikimedia.org/oojs-ui/master/demos/?page=dialogs&theme=wikimediaui&direction=ltr&platform=desktop
VE image dialog (Insert → Images and media)

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.47.3	mediawiki/core	master	+433 -145
Manual backport of OOUI change I63293edd62 (tab dialog fix)	mediawiki/core	master	+5 -1
Manual backport of OOUI change I63293edd62 (tab dialog fix)	mediawiki/core	wmf/1.41.0-wmf.10	+5 -1
Fix hidden-until-found tabs blocking interactions with other tabs	oojs/ui	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: T337531: Preferences search no longer shows results outside of the active tab

Event Timeline

matmarex created this task.May 25 2023, 7:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2023, 7:31 PM

Caused by https://gerrit.wikimedia.org/r/c/oojs/ui/+/894065

Change 923415 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[oojs/ui@master] Fix hidden-until-found tabs blocking interactions with other tabs

https://gerrit.wikimedia.org/r/923415

gerritbot added a project: Patch-For-Review.May 25 2023, 7:39 PM

I'm not entirely sure that this is the right fix, but it works for me, and it will be easy to backport (which I want to do today).

Change 923415 merged by jenkins-bot:

[oojs/ui@master] Fix hidden-until-found tabs blocking interactions with other tabs

https://gerrit.wikimedia.org/r/923415

matmarex added a project: Browser-Support-Google-Chrome.May 25 2023, 7:43 PM

matmarex updated the task description. (Show Details)

Change 923417 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Manual backport of OOUI change I63293edd62 (tab dialog fix)

https://gerrit.wikimedia.org/r/923417

Change 923282 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@wmf/1.41.0-wmf.10] Manual backport of OOUI change I63293edd62 (tab dialog fix)

https://gerrit.wikimedia.org/r/923282

matmarex added a project: Editing-team (Kanban Board).May 25 2023, 8:31 PM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.

Change 923282 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.10] Manual backport of OOUI change I63293edd62 (tab dialog fix)

https://gerrit.wikimedia.org/r/923282

Mentioned in SAL (#wikimedia-operations) [2023-05-25T20:38:23Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:923282|Manual backport of OOUI change I63293edd62 (tab dialog fix) (T337515)]]

Change 923417 merged by jenkins-bot:

[mediawiki/core@master] Manual backport of OOUI change I63293edd62 (tab dialog fix)

https://gerrit.wikimedia.org/r/923417

Mentioned in SAL (#wikimedia-operations) [2023-05-25T20:40:04Z] <samtar@deploy1002> samtar and matmarex: Backport for [[gerrit:923282|Manual backport of OOUI change I63293edd62 (tab dialog fix) (T337515)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-25T20:46:58Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:923282|Manual backport of OOUI change I63293edd62 (tab dialog fix) (T337515)]] (duration: 08m 34s)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 25 2023, 9:00 PM