Page MenuHomePhabricator

[M] Temporary Accounts on iOS: Log in and create account
Closed, ResolvedPublic3 Estimated Story Points

Description

Summary of updates

Outlined below are proposed updates to the iOS log in and create account flows. These updates were made to reflect proposed changes on desktop web related to IP masking work. Text in the screens below comes from proposed strings in the IP masking Figma file and may be subject to change.

Relevant links

Proposed designs

Log inCreate accountCreate account - blocked characters
image.png (1×750 px, 124 KB)
image.png (1×750 px, 234 KB)
image.png (1×750 px, 182 KB)
Shown when a user with a temporary account goes to log inShown when a user with a temporary account goes to create a new accountShown after a user submits a username with blocked characters / strings

Notes

  • What characters / strings will be blocked will be determined by AHT and this ticket / validation text will need to be updated to reflect the final decision AHT makes.

Engineering Notes

  • Code: LoginViewController and WMFAccountCreationViewController
  • Lets continue showing login / create account in full screen instead of the page sheet modal style. This is the way it's currently showing and will save us some time.
  • Create a reusable banner component to embed into the login and create account views. Create component in the WMFComponents package. This component must be able to embed within a UIKit context, but internals can be SwiftUI if preferred (i.e. use a hosting controller if component is SwiftUI).
  • With the merged PR from https://github.com/wikimedia/wikipedia-ios/pull/4647, the create account screen should already actively check if the username is available for use when you leave focus of the Username field. Hopefully this error just works if the user tries a temp account pattern. Worst-case-scenario, if we have to add client-side pattern checking, check for usernames that begin with ~2 (reference: https://wikimedia.slack.com/archives/C04JEEZH6AY/p1725900987967539?thread_ts=1725895652.936209&cid=C04JEEZH6AY)
  • Mocks for "Read more" view that is pushed on can be found in T340790.
  • Also includes padding movement from https://phabricator.wikimedia.org/T374012 (Robin's design feedback)
  • Design feedback/Q+A here: https://wikimedia.slack.com/archives/C4DDMJ9CH/p1740669602367189 (including information on design changes regarding navigation)

Test Steps

  1. In a temporary account, go to a log in or create account page
  2. Ensure toast is there

Experimental Build 238

Event Timeline

Is there a reason that "will not be carried over" is used here instead of "will not be attributed"? I'm a native English speaker so I can't really speak for those who have it as a second (or third) language, but it seems like it makes sense to remove any potential confusion and ambiguity with the wording - especially for those people. Obviously this isn't just limited to the mobile site/app, but I'm not sure where else this is being discussed.

@JaydenKieran thanks for taking a look at this ticket. I believe this copy was updated by the Growth / AHT teams after usability testing: https://phabricator.wikimedia.org/T328368

LGoto triaged this task as Medium priority.May 30 2023, 6:17 PM
LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.
HNordeenWMF renamed this task from IP Masking on iOS: Log in and create account to Temporary Accounts on iOS: Log in and create account.Apr 2 2024, 4:04 PM
Tsevener renamed this task from Temporary Accounts on iOS: Log in and create account to [M] Temporary Accounts on iOS: Log in and create account.Sep 5 2024, 5:13 PM

Eng sync notes:

  • Lets show login / create account in full screen instead of the sheet. This is the way it's currently showing and will save us some time.
  • What are the special characters that are not allowed? Is it only asterisks? Ideally the API will hopefully send us an error message for us which we already display by default. This way we can avoid adding any duplicate client-side logic.
  • Error handling from the API seems to currently show as a banner by default, not beneath the textfield (see screenshot from a username with "WMF"). A banner might be better for Voice Over support.

Screenshot 2024-09-05 at 12.09.59 PM (1×559 px, 258 KB)

Seddon lowered the priority of this task from Medium to Low.Dec 10 2024, 6:15 PM
Tsevener updated the task description. (Show Details)
HNordeenWMF raised the priority of this task from Low to Medium.Dec 19 2024, 10:21 PM
Seddon set the point value for this task to 3.Jan 8 2025, 7:03 PM
HNordeenWMF lowered the priority of this task from Medium to Low.Jan 16 2025, 8:21 PM
HNordeenWMF subscribed.

@Tsevener @GOlson-WMF
There was a mistake here in the Copy in Figma that we should fix. (Not your fault, you were following designs!)

For the "read more" screen accessed from log-in when someone has a temporary account and they are logging in or creating account, we need to let them know that contributions won't transfer over.

Update copy:
You are currently using a temporary account. Edits made with the temporary account ~YYYY-nnnnn-nn will not be carried over to your permanent account when you log in. Log in or create an account to get credit to your username, among other benefits. (CTA buttons can stay the same)

Android equivalentiOS account creation point after having made edits on a temporary accountScreen that needs Copy to be updated to match Android
Screenshot_20250417-183052.png (2×1 px, 132 KB)
IMG_0277.PNG (2×1 px, 490 KB)
IMG_0280.PNG (2×1 px, 135 KB)