| Wurgl | |
| May 26 2023, 2:40 PM |
| F37672525: image.png | |
| Sep 8 2023, 4:06 PM |
| F37672267: image.png | |
| Sep 8 2023, 2:59 PM |
The page https://superset.wmcloud.org/superset/welcome/ has misplaced </head> and <body>-HTML Tags, causing my browser to show nothing
This is how the source of the page looks like:
…
<input
type="hidden"
name="csrf_token"
id="csrf_token"
value="<removed some longish string>"
>
</head>
<body >
…So, there is an <input>-Tag within the <head> section, where it sure should not be.
Re-tagging, since this is about superset.wmcloud.org.
I suspect that @rook will be best able to triage this ticket, having worked on this Superset instance.
@Wurgl sure enough there is. Could you open an upstream ticket at https://github.com/apache/superset/issues describing the issue?
I do not want to create an account on microsoft owned pages. Sorry, hardcore-linuxer
However: Klick https://superset.wmcloud.org/superset/welcome/ Log in with your wikipedia account and look at the source, you will see the error. Depending on your browser there is just an empty page.
I can confirm that the same output also appears on superset.wikimedia.org - which is currently version 1.5.3
However, I don't get an empty page on either of:
These are the only browsers that I've tested so far.
@Wurgl - could you let us know what browser(s) you've observed being affected please?
I'm sure that we can report it upstream on your behalf, but it would help to have a repeatable test-case of the failure you describe. Thanks.
Okay. My browser is a little bit old. Firefox, chrome an Opera shows a page. However, an input field within the head section is always misplaced, ignored by newer browsers, causing a blank page on my oldish browser.
Thanks @Wurgl - It seems that the code is here in the upstream project and is still present in the master branch:
https://github.com/apache/superset/blob/master/superset/templates/superset/basic.html#L66-L74
I will raise a ticket on GItHub. I checked it out by pasting some sanitized page source to https://validator.w3.org/
Whilst it didn't say that the <input> was misplaced, it rather stated that stray </head> and <body> tags were found.
When I moved the <input> field inside the <body>, these two errors went away.
I have created : https://github.com/apache/superset/issues/25235 with these observations.