Page MenuHomePhabricator

Gallery creation not functional in VisualEditor
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • Enter VisualEditor (Edit) on a Wikipedia page
  • Select Insert...>Gallery in toolbar
  • Observe the issue

What happens?:

When trying to add a new gallery in the visual editor, the user gets the message "The gallery is empty." with no way to add new images as expected.

What should have happened instead?:

The user should have the option to add images to a gallery-in-creation.

Other information:
Initially brought to attention by user Ezzex at the Norwegian bokmål Wikipedia. I could not find a corresponding report before creation of this task.

I have tested in Google Chrome (logged in and logged out) and Firefox (logged out). I've tested on English Wikipedia as well as Norwegian bokmål Wikipedia.

Screenshot below shows the resulting gallery editor

image.png (661×926 px, 24 KB)

Event Timeline

Change 923764 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] ve.ui.MWGalleryDialog: Fix showing the search panel

https://gerrit.wikimedia.org/r/923764

Change 924160 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.10] ve.ui.MWGalleryDialog: Fix showing the search panel

https://gerrit.wikimedia.org/r/924160

Change 923764 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ve.ui.MWGalleryDialog: Fix showing the search panel

https://gerrit.wikimedia.org/r/923764

Change 924458 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.11] ve.ui.MWGalleryDialog: Fix showing the search panel

https://gerrit.wikimedia.org/r/924458

Change 924160 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.10] ve.ui.MWGalleryDialog: Fix showing the search panel

https://gerrit.wikimedia.org/r/924160

Change 924458 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.11] ve.ui.MWGalleryDialog: Fix showing the search panel

https://gerrit.wikimedia.org/r/924458

Mentioned in SAL (#wikimedia-operations) [2023-05-30T15:00:08Z] <tgr@deploy1002> Started scap: Backport for [[gerrit:924160|ve.ui.MWGalleryDialog: Fix showing the search panel (T337638)]], [[gerrit:924456|Hide 'editnotice-notext' message in VE (and mobile apps) (T337633)]], [[gerrit:924458|ve.ui.MWGalleryDialog: Fix showing the search panel (T337638)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-30T15:02:04Z] <tgr@deploy1002> tgr and matmarex: Backport for [[gerrit:924160|ve.ui.MWGalleryDialog: Fix showing the search panel (T337638)]], [[gerrit:924456|Hide 'editnotice-notext' message in VE (and mobile apps) (T337633)]], [[gerrit:924458|ve.ui.MWGalleryDialog: Fix showing the search panel (T337638)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-30T15:08:17Z] <tgr@deploy1002> Finished scap: Backport for [[gerrit:924160|ve.ui.MWGalleryDialog: Fix showing the search panel (T337638)]], [[gerrit:924456|Hide 'editnotice-notext' message in VE (and mobile apps) (T337633)]], [[gerrit:924458|ve.ui.MWGalleryDialog: Fix showing the search panel (T337638)]] (duration: 08m 08s)

matmarex added a project: Skipped QA.

Fixed and deployed to Wikimedia projects.