Page MenuHomePhabricator
Create Task
Maniphest T337664

Deprecate hook Translate:GettextFFS:headerFields in favor of Translate:GettextFormat:headerFields
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The hook Translate:GettextFFS:headerFields should be deprecated following changes in this patch: GettextFFS::class: Move to FileFormatSupport namespace. The hook should be renamed to Translate:GettextFormat:headerFields following the next MLEB release 2023.07

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add interface for Translate:GettextFormat:headerFields hookAbijeet Patromediawiki/extensions/Translatemaster+52 -3
Translate:GettextFFS:headerFields: Perform hard deprecationAbijeet Patromediawiki/extensions/Translatemaster+1 -2
Deprecate use of Translate:GettextFFS:headerFields hook.Wangombemediawiki/extensions/Translatemaster+14 -0
Deprecate use of Translate:GettextFFS:headerFields hook.Wangombetranslatewikimaster+3 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Wangombe created this task.May 29 2023, 7:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2023, 7:57 AM
• Wangombe renamed this task from Deprecate Translate:GettextFFS:headerFields in favor of Translate:GettextFormat:headerFields to Deprecate hook Translate:GettextFFS:headerFields in favor of Translate:GettextFormat:headerFields.May 29 2023, 8:01 AM
• Wangombe triaged this task as Low priority.
• Wangombe added a project: Language-Team (Language-2023-April-June).
• Wangombe updated the task description. (Show Details)
• Wangombe updated the task description. (Show Details)
abi_ edited projects, added: MediaWiki Language Extension Bundle; removed: Language-Team (Language-2023-April-June).May 29 2023, 8:04 AM
• Wangombe moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.May 29 2023, 8:04 AM
• Nikerabbit mentioned this in T340729: Release MLEB 2023.07.Jul 5 2023, 6:22 AM
• Nikerabbit added a parent task: T355104: Release MLEB 2024.01.Jan 16 2024, 8:49 AM
• Nikerabbit added a project: Language-Team (Language-2024-January-March).Jan 16 2024, 8:53 AM
• Nikerabbit raised the priority of this task from Low to High.Jan 16 2024, 8:57 AM
• Nikerabbit set the point value for this task to 2.
• Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2024-January-March) board.
• Nikerabbit added a project: Localization Infrastructure FY2023-24.
• Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.
• Wangombe changed the task status from Open to In Progress.Jan 17 2024, 7:25 AM
• Wangombe claimed this task.
• Wangombe moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2024-January-March) board.
• Wangombe updated the task description. (Show Details)Jan 17 2024, 8:09 AM
gerritbot added a comment.Jan 17 2024, 8:53 AM

Change 991280 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Deprecate use of Translate:GettextFFS:headerFields hook.

https://gerrit.wikimedia.org/r/991280

gerritbot added a project: Patch-For-Review.Jan 17 2024, 8:53 AM

Change 991281 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Deprecate use of Translate:GettextFFS:headerFields hook.

https://gerrit.wikimedia.org/r/991281

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2024-January-March) board.Jan 21 2024, 5:18 AM
abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2024-January-March) board.Jan 22 2024, 2:56 PM
gerritbot added a comment.Jan 22 2024, 3:33 PM

Change 991280 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Deprecate use of Translate:GettextFFS:headerFields hook.

https://gerrit.wikimedia.org/r/991280

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 22 2024, 4:00 PM
gerritbot added a comment.Jan 23 2024, 10:21 AM

Change 991281 merged by jenkins-bot:

[translatewiki@master] Deprecate use of Translate:GettextFFS:headerFields hook.

https://gerrit.wikimedia.org/r/991281

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2024, 10:30 AM
gerritbot added a comment.Jan 23 2024, 10:44 AM

Change 992180 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Translate:GettextFFS:headerFields: Perform hard deprecation

https://gerrit.wikimedia.org/r/992180

gerritbot added a project: Patch-For-Review.Jan 23 2024, 10:44 AM
gerritbot added a comment.Jan 23 2024, 11:32 AM

Change 992185 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add interface for Translate:GettextFormat:headerFields hook

https://gerrit.wikimedia.org/r/992185

gerritbot added a comment.Jan 23 2024, 1:06 PM

Change 992180 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Translate:GettextFFS:headerFields: Perform hard deprecation

https://gerrit.wikimedia.org/r/992180

ReleaseTaggerBot edited projects, added: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30); removed: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 23 2024, 2:00 PM
gerritbot added a comment.Jan 24 2024, 8:18 AM

Change 992185 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add interface for Translate:GettextFormat:headerFields hook

https://gerrit.wikimedia.org/r/992185

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2024, 8:31 AM
Tacsipacsi subscribed.Jan 24 2024, 8:36 AM
• Wangombe added a comment.EditedJan 31 2024, 4:03 AM

The hook Translate:GettextFFS:headerFields was soft deprecated and later in hard deprecated in favor of adding an interface, GettextFormatHeaderFieldsHook.php, that will triggered using the HookRunner. Hook interfaces were added in Mediawiki 1.35 --> T338451

abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2024-January-March) board.Jan 31 2024, 8:04 AM

Latest changes available in MLEB 2024.01: https://lists.wikimedia.org/hyperkitty/list/mediawiki-i18n@lists.wikimedia.org/thread/ENMQ6RFBNZCEBKAGIEPH77NUAI4JYCTP/

abi_ closed this task as Resolved.Jan 31 2024, 8:10 AM
• Nikerabbit moved this task from Backlog to 2023.10 on the MediaWiki Language Extension Bundle board.Feb 7 2024, 8:30 AM
• Nikerabbit moved this task from 2023.10 to 2024.01 on the MediaWiki Language Extension Bundle board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits