Prevent Echo Extension from setting preferences for temporary accounts
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• AGueyte
	May 30 2023, 5:10 PM

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

includes/Api/ApiEchoMute.php
includes/EmailBatch.php
includes/Special/SpecialDisplayNotificationsConfiguration.php
tests/phpunit/DiscussionParserTest.php

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js
Code Search: https://codesearch.wmcloud.org/deployed/?q=UserOptionsManager

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• AGueyte	T335971 Prevent extensions from setting preferences for temporary accounts
		Resolved		• AGueyte	T337771 Prevent Echo Extension from setting preferences for temporary accounts

Event Timeline

• AGueyte created this task.May 30 2023, 5:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2023, 5:10 PM

• AGueyte updated the task description. (Show Details)May 30 2023, 5:20 PM

@AGueyte: Assuming this task is about the Notifications code project, thus adding that project tag so people can also find this task when searching via projects or looking at workboards. Please set appropriate project tags when possible. Thanks!