Prevent Popups from setting preferences for temporary accounts
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• AGueyte
	May 30 2023, 5:56 PM

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.
Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js
Code Search: https://codesearch.wmcloud.org/deployed/?q=UserOptionsManager

Details

	Subject	Repo	Branch	Lines +/-
	Prevent Enabling Beta Preferences for temp users	mediawiki/extensions/Popups	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• AGueyte	T335971 Prevent extensions from setting preferences for temporary accounts
		Resolved		• AGueyte	T337776 Prevent Popups from setting preferences for temporary accounts

Event Timeline

• AGueyte created this task.May 30 2023, 5:56 PM

(Please add codebase project tags to tasks when possible, so such tasks can be found when looking for open tasks related to that codebase - thanks!)

• AGueyte added a project: Anti-Harassment (AHaT Sprint 31 - The Fez).Jun 6 2023, 7:35 PM

• AGueyte updated the task description. (Show Details)

• AGueyte set the point value for this task to 2.

• AGueyte changed the task status from Open to In Progress.Jun 7 2023, 6:27 PM

• AGueyte claimed this task.

• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.

Change 928557 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/Popups@master] Prevent Enabling Beta Preferences for temp users

https://gerrit.wikimedia.org/r/928557

gerritbot added a project: Patch-For-Review.Jun 8 2023, 2:09 PM

• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 8 2023, 2:21 PM

Hey @AGueyte there seems to be overlap with this task and the one I'm currently working on in T330517 so let's chat before merging any code here!

In T337776#8914279, @Jdlrobson wrote:

Hey @AGueyte there seems to be overlap with this task and the one I'm currently working on in T330517 so let's chat before merging any code here!

Noted, I'll add a note on the patch for visibility.
Thanks for this update!

Change 928557 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Prevent Enabling Beta Preferences for temp users

https://gerrit.wikimedia.org/r/928557

Maintenance_bot removed a project: Patch-For-Review.Jun 12 2023, 7:10 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 12 2023, 8:00 PM

• AGueyte moved this task from Blocked/Stalled 🚧 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 13 2023, 12:08 PM

• AGueyte closed this task as Resolved.Jun 19 2023, 2:40 PM

phuedx unsubscribed.Jul 5 2023, 9:18 AM