Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.
Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).
Tests and comments should also be updated.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't set preferences for temporary accounts | mediawiki/extensions/FileImporter | master | +5 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| In Progress | Niharika | T324492 Temporary accounts - MVP | |||
| Resolved | • AGueyte | T335971 Prevent extensions from setting preferences for temporary accounts | |||
| Resolved | • AGueyte | T337777 Prevent FileImporter from setting preferences for temporary accounts |
(Please add codebase project tags to tasks when possible, so such tasks can be found when looking for open tasks related to that codebase - thanks!)
Change 925839 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Don't set references for temporary accounts
Change 925839 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Don't set preferences for temporary accounts