Prevent GlobalWatchlist from setting preferences for temporary accounts
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js

Details

	Subject	Repo	Branch	Lines +/-
	Prevent Temp Users from saving UserOptions preferences	mediawiki/extensions/GlobalWatchlist	master	+7 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• AGueyte	T335971 Prevent extensions from setting preferences for temporary accounts
		Resolved		• AGueyte	T337778 Prevent GlobalWatchlist from setting preferences for temporary accounts

Event Timeline

• AGueyte created this task.May 30 2023, 6:03 PM

(Please add codebase project tags to tasks when possible, so such tasks can be found when looking for open tasks related to that codebase - thanks!)

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 30 2023, 9:47 PM

• AGueyte edited projects, added Anti-Harassment (AHaT Sprint 31 - The Fez); removed User-DannyS712.Jun 6 2023, 5:55 PM

• AGueyte set the point value for this task to 3.Jun 6 2023, 5:58 PM

Aklapper added a project: User-DannyS712.Jun 7 2023, 1:15 PM

• AGueyte claimed this task.Jun 12 2023, 12:31 PM

• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.

• AGueyte removed a project: User-DannyS712.

Change 929345 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/GlobalWatchlist@master] Prevent Temp Users from saving UserOptions preferences

https://gerrit.wikimedia.org/r/929345

gerritbot added a project: Patch-For-Review.Jun 12 2023, 2:06 PM

• AGueyte changed the task status from Open to In Progress.Jun 12 2023, 2:07 PM

@AGueyte: Please don't remove people's project tags (or explain why). Thanks!

• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 12 2023, 2:25 PM

• AGueyte moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 15 2023, 12:11 PM

• AGueyte moved this task from In Progress 💪 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 15 2023, 1:13 PM

• AGueyte moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.

• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 18 2023, 5:31 AM

Change 929345 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Prevent Temp Users from saving UserOptions preferences

https://gerrit.wikimedia.org/r/929345

Maintenance_bot removed a project: Patch-For-Review.Jun 18 2023, 6:10 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 18 2023, 7:00 AM

• Niharika edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment (AHaT Sprint 31 - The Fez).Jun 20 2023, 6:04 PM

• Niharika moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jun 20 2023, 6:05 PM

@AGueyte Invalid exception error before the patch and now you must be logged in after the patch as a temp user. I will move this to Done. Thanks!

Before Patch

T337778_IPMasking_GlobalWatchlistSettings_Pre.png (890×3 px, 409 KB)

Post Patch

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jun 20 2023, 10:00 PM

• AGueyte closed this task as Resolved.Jun 21 2023, 1:05 PM

	F37110605: T337778_IPMasking_GlobalWatchlistSettings_Post.png
	Jun 20 2023, 9:59 PM

	F37110603: T337778_IPMasking_GlobalWatchlistSettings_Pre.png
	Jun 20 2023, 9:59 PM

Prevent GlobalWatchlist from setting preferences for temporary accounts Closed, ResolvedPublic3 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

Prevent GlobalWatchlist from setting preferences for temporary accounts
Closed, ResolvedPublic3 Estimated Story Points
Actions

Related Objects
Search...