Page MenuHomePhabricator
Create Task
Maniphest T337782

Prevent CentralAuth from setting preferences for temporary accounts
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js

Details

SubjectRepoBranchLines +/-
SpecialCentralAutoLogin: Shift scope of $user->isNamed() checkmediawiki/extensions/CentralAuthmaster+3 -5
Prevent CentralAuth from setting preferences for temporary accountsmediawiki/extensions/CentralAuthmaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• AGueyte created this task.May 30 2023, 6:19 PM
Aklapper added a project: MediaWiki-extensions-CentralAuth.May 30 2023, 9:46 PM

(Please add codebase project tags to tasks when possible, so such tasks can be found when looking for open tasks related to that codebase - thanks!)

• AGueyte added a project: Anti-Harassment (AHaT Sprint 31 - The Fez).Jun 6 2023, 5:55 PM
• AGueyte set the point value for this task to 3.Jun 6 2023, 5:58 PM
• TThoabala claimed this task.Jun 14 2023, 11:42 PM
• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 15 2023, 7:18 PM
• AGueyte changed the task status from Open to In Progress.Jun 16 2023, 11:07 AM
• AGueyte moved this task from In Progress 💪 to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 20 2023, 12:40 PM
gerritbot added a comment.Jun 20 2023, 4:59 PM

Change 931652 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/CentralAuth@master] Prevent CentralAuth from setting preferences for temporary accounts

https://gerrit.wikimedia.org/r/931652

gerritbot added a project: Patch-For-Review.Jun 20 2023, 4:59 PM
gerritbot added a comment.Jun 20 2023, 5:08 PM

Change 931652 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Prevent CentralAuth from setting preferences for temporary accounts

https://gerrit.wikimedia.org/r/931652

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2023, 5:11 PM
• AGueyte moved this task from Blocked/Stalled 🚧 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 20 2023, 5:26 PM
gerritbot added a comment.Jun 20 2023, 5:59 PM

Change 931667 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/CentralAuth@master] SpecialCentralAutoLogin: Shift scope of $user->isNamed() check

https://gerrit.wikimedia.org/r/931667

gerritbot added a project: Patch-For-Review.Jun 20 2023, 5:59 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 20 2023, 6:00 PM
• Niharika edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment (AHaT Sprint 31 - The Fez).Jun 20 2023, 6:04 PM
• Niharika moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jun 20 2023, 6:05 PM
gerritbot added a comment.Jun 20 2023, 6:48 PM

Change 931667 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SpecialCentralAutoLogin: Shift scope of $user->isNamed() check

https://gerrit.wikimedia.org/r/931667

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2023, 7:10 PM
• TThoabala moved this task from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jun 21 2023, 11:06 AM
• AGueyte closed this task as Resolved.Jun 21 2023, 1:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL