Prevent TwoColConflict from setting preferences for temporary accounts
Closed, ResolvedPublic
Actions

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Don't set preferences for temporary accounts	mediawiki/extensions/TwoColConflict	master	+2 -2

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
Resolved	Niharika	T324492 Temporary accounts - MVP
Resolved	• AGueyte	T335971 Prevent extensions from setting preferences for temporary accounts
Resolved	• AGueyte	T337789 Prevent TwoColConflict from setting preferences for temporary accounts

(Please add codebase project tags to tasks when possible, so such tasks can be found when looking for open tasks related to that codebase - thanks!)

Change 925836 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] Don't set references for temporary accounts

Change 925836 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Don't set preferences for temporary accounts

• AGueyte claimed this task.