Page MenuHomePhabricator
Create Task
Maniphest T337798

Prevent WikimediaMessages from setting preferences for temporary accounts
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js

https://codesearch.wmcloud.org/deployed/?q=UserOptionsManager#mediawiki/extensions/WikimediaMessages

Details

SubjectRepoBranchLines +/-
prevent temp users from seeing RCFilters guided toursmediawiki/extensions/WikimediaMessagesmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• AGueyte created this task.May 30 2023, 8:06 PM
Aklapper added a project: WikimediaMessages.May 30 2023, 9:46 PM

(Please add codebase project tags to tasks when possible, so such tasks can be found when looking for open tasks related to that codebase - thanks!)

• AGueyte added a project: Anti-Harassment (AHaT Sprint 31 - The Fez).Jun 6 2023, 5:56 PM
• AGueyte set the point value for this task to 2.
• AGueyte changed the task status from Open to In Progress.Jun 8 2023, 2:22 PM
• AGueyte changed the task status from In Progress to Open.
• AGueyte claimed this task.
• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.
gerritbot added a comment.Jun 8 2023, 3:36 PM

Change 927779 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/WikimediaMessages@master] prevent temp users from seeing RCFilters guided tours

https://gerrit.wikimedia.org/r/927779

gerritbot added a project: Patch-For-Review.Jun 8 2023, 3:36 PM
• AGueyte changed the task status from Open to In Progress.Jun 8 2023, 3:37 PM
• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 8 2023, 8:39 PM
• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 12 2023, 5:19 AM
gerritbot added a comment.Jun 12 2023, 5:37 AM

Change 927779 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] prevent temp users from seeing RCFilters guided tours

https://gerrit.wikimedia.org/r/927779

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 12 2023, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 12 2023, 6:10 AM
dom_walden moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 20 2023, 2:12 PM
dom_walden subscribed.

I went to Special:RecentChanges on different wikis as an anonymous, temporary and named user, to see whether or not the RecentChanges Filters tour showed.

WikiAnonTempNamed
dewiki betaNo tourNo tourTour
enwiki betaNo tourNo tour(!)Tour
testwikiNo tourN/ATour

(To test whether named users saw the tour, I first had to reset my preferences.)

For the "temp" user on enwiki beta, I made an edit on dewiki beta so it would autocreate a temp account. Then I went to enwiki, where CA logged me in as the temp user. I was expecting the temporary user on enwiki to be treated as a named user, and so be shown the tour. However, this did not happen.

Tchanders closed this task as Resolved.Aug 14 2023, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL