Page MenuHomePhabricator

Vector 2022: consider adding the "hide" button in the pinned menus when "move to sidebar" is not shown
Closed, DeclinedPublicFeature

Description

Feature summary
In Vector 2022, when the menu is pinned and the "move to sidebar" link/button isn't present, the "hide" button should be shown instead.
Because the "hide" button is present in other cases, and because users could be not aware that they can close the menu just by clicking on the burger icon or on the word "Tools".

Use case
Open a random page on Wikipedia, for exemple the Main page and try the different modes of the Main menu.

With the Main menu pinned, when you are using a narrow screen or window, or when you are zooming in a lot, the "move to sidebar" link/button isn't shown, but nothing is shown instead. (screenshots)

Benefits (why should this be implemented?):
Improve accessibility for visual impairments or technologically impaired users.

Context

In Vector 2022, menus could be open, collapsed or pinned.
For switching between different modes, in general

  • when the menu is open, the "hide" link/button allows to collapse it within the icon
  • when the menu is closed, to pin the menu you have to click on the icon
  • when the menu is pinned, the "move to sidebar" link/button allows to open it

In some cases no instructions are given, which may confuse users.

This should be one of the problems reported by a user (who also has other problems with JS) here and elsewhere (his configuration: Mozilla Firefox iMAC OSX version 10.7.5, screen 21.5 inches).

Tested both with narrow window and by zooming at 150%, with PC, Windows, Firefox, display resolution 1920x1080

Capture d’écran (665).jpg (768×1 px, 339 KB)

Capture d’écran (663).png (768×1 px, 785 KB)

Event Timeline

Patafisik_WMF renamed this task from Vector 2022: consider adding the "hide" button in the pinned Main menu when "move to sidebar" is not shown to Vector 2022: consider adding the "hide" button in the pinned menus when "move to sidebar" is not shown.May 31 2023, 11:21 AM

Thanks for filing this task @Patafisik_WMF! If I'm understanding this right I think theres some terminology/behavior that needs to be clarified first.

By default the main menu is located in the header where it is a dropdown that can be opened or closed by clicking the "hamburger" button. The main menu can be moved to the sidebar by pressing the 'pin to sidebar' button, where it is always visible

Given all that, I believe whats described in this task is expected behavior. The 'hide' and 'pin to sidebar' buttons are used to move the main menu to the header and sidebar respectively. On smaller screensizes, this functionality is disabled because the screen is too small for a sidebar. In this case the main menu can only be located in the header, so both buttons are hidden.

Let me know if this covers your concerns, in the meantime I will be closing this task