Page MenuHomePhabricator

Prevent Thanks from setting preferences for temporary accounts
Closed, ResolvedPublic


Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js:

Event Timeline

Change 925680 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Thanks@master] Hooks: Don't set Echo options for temp users

Change 925680 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Hooks: Don't set Echo options for temp users