Page MenuHomePhabricator

Prevent LDAP Authentication from setting preferences for temporary accounts
Closed, DeclinedPublic2 Estimated Story Points

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

https://www.mediawiki.org/wiki/Extension:LDAP_Authentication

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).
Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js:

This extension is unmaintained - please investigate if it's worth updating.

Event Timeline

As mention in the description and from documentation here
This extension is currently not actively maintained, and it has been replaced by LDAPAuthentication2.
we can close this task as resolved/not-doing ?
@AGueyte

Thanks for looking into this @TThoabala!

From the documentation it looks as though this is used on wikitech, which might be why it appeared in the code search for deployed extensions. Could we look into what would be needed to fix it?

Does it look as though LDAPAuthentication2 needs fixing at all?

AGueyte changed the task status from Open to In Progress.Jun 8 2023, 1:29 PM
Aklapper changed the task status from Resolved to Declined.Jun 8 2023, 2:53 PM
Aklapper removed TThoabala as the assignee of this task.
Aklapper added a subscriber: TThoabala.

Not resolved; thus declining