In the wmf-config repository, we currently keep two inlined copies of source code we actually maintain elsewhere:
In order to simplify ownership and maintenance of these, I suggest we consider linking these direclty somehow. Perhaps we could use two git-submodule references for this?
Change 926574 had a related patch set uploaded (by Krinkle; author: Krinkle):
[operations/mediawiki-config@master] Profiler: Replace copy of ExcimerClient.php with git submodule
Change 926574 merged by jenkins-bot:
[operations/mediawiki-config@master] Profiler: Replace copy of ExcimerClient.php with git submodule
Consuming ArcLamp.php directly is impractical at the moment because we have k8s-specific modifications. I will instead improve both versions to take the best bits of both, clean them up a bit, and improve their docs, but keep the wmf-config version as an embedded copy that is "inspired" by the ArcLamp client example rather than direclty consuming it.
Change 939754 had a related patch set uploaded (by Krinkle; author: Krinkle):
[performance/arc-lamp@master] ArcLamp.php: Apply misc Wikimedia Foundation changes since 2019
Change 939755 had a related patch set uploaded (by Krinkle; author: Krinkle):
[operations/mediawiki-config@master] Profiler: Remove "toobig" filter from Arc Lamp ingestion
Change 939756 had a related patch set uploaded (by Krinkle; author: Krinkle):
[operations/mediawiki-config@master] Profiler: Sync minor changes with arc-lamp.git package
Change 939755 merged by jenkins-bot:
[operations/mediawiki-config@master] Profiler: Remove "toobig" filter from Arc Lamp ingestion
Change 939754 merged by jenkins-bot:
[performance/arc-lamp@master] ArcLamp.php: Apply misc Wikimedia Foundation changes since 2019
Change 939756 merged by jenkins-bot:
[operations/mediawiki-config@master] Profiler: Sync minor changes with arc-lamp.git package
Mentioned in SAL (#wikimedia-operations) [2023-08-02T22:07:36Z] <krinkle@deploy1002> Started scap: Backport for [[gerrit:939756|Profiler: Sync minor changes with arc-lamp.git package (T337873)]]
Mentioned in SAL (#wikimedia-operations) [2023-08-02T22:09:24Z] <krinkle@deploy1002> krinkle: Backport for [[gerrit:939756|Profiler: Sync minor changes with arc-lamp.git package (T337873)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)
Mentioned in SAL (#wikimedia-operations) [2023-08-02T22:18:39Z] <krinkle@deploy1002> Finished scap: Backport for [[gerrit:939756|Profiler: Sync minor changes with arc-lamp.git package (T337873)]] (duration: 11m 02s)