Maniphest T337874

Prevent Skins Vector from setting preferences for temporary accounts
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• AGueyte
	May 31 2023, 4:09 PM

Tags

Referenced Files

None

Subscribers

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

https://codesearch.wmcloud.org/deployed/?q=UserOptionsManager#mediawiki/skins/Vector

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Prevent Skins Vector from setting preferences for temporary accounts	mediawiki/skins/Vector	master	+17 -17

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
					Restricted Task
		Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
		Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
		Resolved		Niharika	T324492 Temporary accounts - MVP
		Resolved		• AGueyte	T335971 Prevent extensions from setting preferences for temporary accounts
		Resolved		• TThoabala	T337874 Prevent Skins Vector from setting preferences for temporary accounts

Event Timeline

• AGueyte created this task.May 31 2023, 4:09 PM

Mainframe98 subscribed.May 31 2023, 7:38 PM

• AGueyte added a project: Anti-Harassment-Team (AHaT Sprint 31 - The Fez).Jun 6 2023, 5:58 PM

• AGueyte set the point value for this task to 2.

• TThoabala claimed this task.Jun 7 2023, 8:26 AM

• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 31 - The Fez) board.

Change 928010 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/skins/Vector@master] Prevent Skins Vector from setting preferences for temporary accounts

https://gerrit.wikimedia.org/r/928010

gerritbot added a project: Patch-For-Review.Jun 7 2023, 11:47 AM

• AGueyte changed the task status from Open to In Progress.Jun 7 2023, 12:19 PM

Mainframe98 mentioned this in T338348: Don't try to save a right rail preference for temporary accounts.Jun 7 2023, 5:29 PM

• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 31 - The Fez) board.Jun 7 2023, 6:15 PM

• AGueyte moved this task from Code Review 🔍 to Blocked/Stalled 🚧 on the Anti-Harassment-Team (AHaT Sprint 31 - The Fez) board.Jun 9 2023, 3:56 PM

• AGueyte moved this task from Blocked/Stalled 🚧 to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 31 - The Fez) board.Jun 13 2023, 12:05 PM

• TThoabala moved this task from In Progress 💪 to Blocked/Stalled 🚧 on the Anti-Harassment-Team (AHaT Sprint 31 - The Fez) board.Jun 14 2023, 3:30 PM

Change 928010 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Prevent Skins Vector from setting preferences for temporary accounts

https://gerrit.wikimedia.org/r/928010

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 14 2023, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 14 2023, 9:10 PM

• TThoabala moved this task from Blocked/Stalled 🚧 to Done Q2 2022-2023 on the Anti-Harassment-Team (AHaT Sprint 31 - The Fez) board.Jun 14 2023, 11:47 PM

• TThoabala moved this task from Done Q2 2022-2023 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 31 - The Fez) board.

• TThoabala moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment-Team (AHaT Sprint 31 - The Fez) board.Jun 15 2023, 7:45 PM

• AGueyte closed this task as Resolved.Jun 19 2023, 2:40 PM