Page MenuHomePhabricator

Composer details are wrong
Closed, ResolvedPublicBUG REPORT

Description

The composer.json of WikiSEO has a name of mediawiki/wiki-seo but that's not correct (it doesn't exist). The name should be octfx/wiki-seo.

The other issue is that that packagist record points to https://github.com/octfx/wiki-seo as the source, rather than https://gerrit.wikimedia.org/g/mediawiki/extensions/WikiSEO

There seems to be an issue with version numbers too. There's a 2.6.6 version in the Gerrit composer.json, but that probably doesn't need to be there because Composer should just read from the Git tags to find the versions. Getting rid of it would make things easier to keep up to date too.

Event Timeline

Change 925651 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiSEO@master] Fix Composer name and remove version number

https://gerrit.wikimedia.org/r/925651

I was trying to get wikiseo into the mediawiki packagist namespace, but to no avail.

See https://m.mediawiki.org/wiki/User_talk:Legoktm#c-Octfx-20221203135900-WikiSEO_Composer

That’s why the namespace was changed.
As the extension is developed and hosted in gerrit I'd like to deprecate my GitHub repo

Ah, that makes sense. Good idea! But there's definitely some varying opinions around whether we should even use Composer to install extensions, so it might be hard to convince people to register that package name.

However, you can carry on using your own namespace for the package, but still use Gerrit. That's how I'm doing it for a few extensions. I think you can just switch the source repository via the Packagist UI.

Never thought of this
I've updated the source on packagist, many thanks!

Great! Thanks.

I think you might have to make a new tag to force it to update, maybe one higher than 2.6.6 because that one was already tagged in the GitHub repo but wasn't tagged in the Gerrit one.

Change 925651 merged by jenkins-bot:

[mediawiki/extensions/WikiSEO@master] Fix Composer name and remove version number

https://gerrit.wikimedia.org/r/925651

@Octfx I think this still needs a new release tagged. The latest in the Gerrit repo is still 2.6.5.

Whoops, thanks for the reminder!
Just pushed the tag.

Thanks!

It looks like there's a bunch of work since 2.6.6; is that not ready for release?

I stopped tagging with the move to REL branches.

But for composer to work I'll release from master for all following features.

Further, I've tagged v2.7.0 just now 😊