Page MenuHomePhabricator
Create Task
Maniphest T337955

Edit buttons not appearing within sticky header
Closed, ResolvedPublic
Actions

Description

In T296910, we introduced edit buttons within the sticky header the Vector 2022, and now Zebra, skins implemented.

Those edit buttons no longer seem to be appearing.

Reproduction steps

  1. On desktop, while logged in, visit any Wikipedia page that you have permission to access. E.g. https://en.wikipedia.org/wiki/Improvisation .

❗️Actual

  1. Notice buttons do NOT appear within the sticky header that enable you to edit the page:

Screenshot 2023-06-01 at 8.44.16 AM.png (830×896 px, 248 KB)

✅ Expected

  1. Notice edit buttons appear within the sticky header that enable you to edit the page

QA Results - Prod

ACStatusDetails
1✅T337955#8916862

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove deleted config wgVectorStickyHeaderEditoperations/mediawiki-configmaster+0 -13
Remove config and AB test code for edit buttons in sticky headermediawiki/skins/Vectorwmf/1.41.0-wmf.11+14 -91
Remove config and AB test code for edit buttons in sticky headermediawiki/skins/Vectormaster+14 -91
Customize query in gerrit

Related Objects

Event Timeline

ppelberg created this task.Jun 1 2023, 4:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2023, 4:38 PM
ppelberg added a project: Editing-team (Tracking).Jun 1 2023, 4:38 PM
ppelberg moved this task from Backlog to Dependent on others on the Editing-team (Tracking) board.
Esanders triaged this task as High priority.Jun 1 2023, 4:40 PM
Esanders subscribed.Jun 1 2023, 4:45 PM

Stepping through the code it looks like this being disable by A/B test code. Has the config changed recently or is this just working as expected?

ppelberg added a subscriber: Jdlrobson.Jun 1 2023, 4:46 PM
Jdrewniak subscribed.Jun 1 2023, 4:50 PM
Esanders added a comment.Jun 1 2023, 4:51 PM

T324799 seems to suggest this should be enabled everywhere. I think a recently-enabled AB test has triggered the logic disabling sticky headers again.

gerritbot added a comment.Jun 1 2023, 5:00 PM

Change 925855 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Remove config and AB test code for edit buttons in sticky header

https://gerrit.wikimedia.org/r/925855

gerritbot added a project: Patch-For-Review.Jun 1 2023, 5:00 PM
LGoto edited projects, added Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 4); removed Web-Team-Backlog-Archived.Jun 1 2023, 5:09 PM
LGoto moved this task from Incoming to Doing on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 4) board.
Jdrewniak moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 4) board.Jun 1 2023, 5:09 PM
gerritbot added a comment.Jun 1 2023, 5:12 PM

Change 925858 had a related patch set uploaded (by Esanders; author: Esanders):

[operations/mediawiki-config@master] Remove deleted config wgVectorStickyHeaderEdit

https://gerrit.wikimedia.org/r/925858

gerritbot added a comment.Jun 1 2023, 5:32 PM

Change 925855 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove config and AB test code for edit buttons in sticky header

https://gerrit.wikimedia.org/r/925855

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 1 2023, 6:00 PM
gerritbot added a comment.Jun 1 2023, 6:27 PM

Change 925792 had a related patch set uploaded (by Kimberly Sarabia; author: Esanders):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.11] Remove config and AB test code for edit buttons in sticky header

https://gerrit.wikimedia.org/r/925792

gerritbot added a comment.Jun 1 2023, 8:44 PM

Change 925792 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.11] Remove config and AB test code for edit buttons in sticky header

https://gerrit.wikimedia.org/r/925792

Stashbot added a comment.Jun 1 2023, 8:44 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-01T20:44:29Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:925792|Remove config and AB test code for edit buttons in sticky header (T337955)]]

Stashbot added a comment.Jun 1 2023, 8:45 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-01T20:45:57Z] <samtar@deploy1002> samtar and ksarabia: Backport for [[gerrit:925792|Remove config and AB test code for edit buttons in sticky header (T337955)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Stashbot added a comment.Jun 1 2023, 8:54 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-01T20:54:58Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:925792|Remove config and AB test code for edit buttons in sticky header (T337955)]] (duration: 10m 29s)

gerritbot added a comment.Jun 1 2023, 8:57 PM

Change 925858 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove deleted config wgVectorStickyHeaderEdit

https://gerrit.wikimedia.org/r/925858

Stashbot added a comment.Jun 1 2023, 8:57 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-01T20:57:36Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:925858|Remove deleted config wgVectorStickyHeaderEdit (T337955)]]

Stashbot added a comment.Jun 1 2023, 8:59 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-01T20:59:15Z] <samtar@deploy1002> esanders and samtar: Backport for [[gerrit:925858|Remove deleted config wgVectorStickyHeaderEdit (T337955)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.11; 2023-05-30); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 1 2023, 9:00 PM
matmarex merged a task: T337993: In the Vector 2022 sticky header the edit icons have disappeared.Jun 1 2023, 9:02 PM
matmarex added a subscriber: Patafisik_WMF.
matmarex subscribed.
Stashbot added a comment.Jun 1 2023, 9:06 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-01T21:06:07Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:925858|Remove deleted config wgVectorStickyHeaderEdit (T337955)]] (duration: 08m 30s)

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2023, 9:11 PM
Jdrewniak moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 4) board.Jun 6 2023, 4:44 PM
Jdlrobson added a comment.Jun 8 2023, 2:51 PM

@Jdrewniak who is responsible for QAing and resolving this ticket? Web team or editing team?

Jdlrobson moved this task from QA to QA in Production on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 4) board.Jun 8 2023, 5:34 PM
LGoto assigned this task to Edtadros.Jun 8 2023, 5:35 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.Jun 9 2023, 1:02 AM
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

On desktop, while logged in, visit any Wikipedia page that you have permission to access. E.g. https://en.wikipedia.org/wiki/Improvisation .
✅ AC1: edit buttons appear within the sticky header that enable you to edit the page

Screenshot 2023-06-08 at 5.59.00 PM.png (342×1 px, 80 KB)

@Jdlrobson If this looks good feel free to resolve.

Edtadros updated the task description. (Show Details)Jun 9 2023, 1:03 AM
Jdlrobson closed this task as Resolved.Jun 9 2023, 1:44 AM
jwang mentioned this in T335379: Analyze page separation (Zebra #9) A/B test.Jul 18 2023, 4:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits