Page MenuHomePhabricator

Expose a method to display post-edit notification after reloading the page
Closed, ResolvedPublic

Description

As a result of IP Masking work, several editing tools that previously displayed post-edit notifications without reloading the page now need to reload the page sometimes, and still need to display the notifications. We should provide a method to do that in core, so that it doesn't need to be implemented from scratch in each tool.

Event Timeline

Change 928969 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Add helpers to show post-edit message now and on page reload

https://gerrit.wikimedia.org/r/928969

Change 928971 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Use new helpers to show the post-edit message

https://gerrit.wikimedia.org/r/928971

Change 928973 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Use new helpers to show the post-edit message

https://gerrit.wikimedia.org/r/928973

Change 928969 merged by jenkins-bot:

[mediawiki/core@master] Add helpers to show post-edit message now and on page reload

https://gerrit.wikimedia.org/r/928969

Change 928973 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Use new helpers to show the post-edit message

https://gerrit.wikimedia.org/r/928973

Change 932246 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Fix showing post-edit message on page reload

https://gerrit.wikimedia.org/r/932246

Change 932246 merged by jenkins-bot:

[mediawiki/core@master] Fix showing post-edit message on page reload

https://gerrit.wikimedia.org/r/932246

Change 928971 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use new helpers to show the post-edit message

https://gerrit.wikimedia.org/r/928971

matmarex added a project: Editing QA.

For QA, please test how the post-edit messages behave for edits where VisualEditor (or MobileFrontend editor) reloads the whole page instead of just the content – currently that includes creating a new page, and any edit after switching from old wikitext editor. (In the future it will also include edits that create an IP-masked temporary account. You could test that too on https://de.wikipedia.beta.wmflabs.org/ now, but the user interface for it isn't complete yet.)