Page MenuHomePhabricator

move use of Math.random() to mw.user.getPageviewToken() in probenet.js
Closed, ResolvedPublic

Description

Per @Krinkle

In the future, I would recommend considering something based on mw.user.getPageviewToken(). E.g. target+probe_num_pageviewToken would be unique for your purposes, whilst both saving compute time but also strengthening the unique ness in so far that getPageviewToken uses the browser's Crypto API for its pseudo-random number generating needs.

Event Timeline

CDanis triaged this task as Low priority.

Change 926604 had a related patch set uploaded (by Jameel Kaisar; author: Jameel Kaisar):

[mediawiki/extensions/WikimediaEvents@master] Use mw.user.getPageviewToken instead of Math.random

https://gerrit.wikimedia.org/r/926604

Change 926604 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] networkprobe: Use mw.user.getPageviewToken instead of Math.random

https://gerrit.wikimedia.org/r/926604

CDanis assigned this task to JameelKaisar.