Page MenuHomePhabricator

Special:Log should show error when the input is invalid
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Navigate to Special:Log, e.g. mw:Special:Log
  • Type an invalid title for the target, e.g. >foo
  • Click Show

What happens?:

No error was given, and all logs are present below the form.

Screenshot 2023-06-02 230730.png (1×1 px, 235 KB)

What should have happened instead?:

Error about contains invalid characters should be given, and no logs shown.

Screenshot 2023-06-02 234117.png (1×1 px, 121 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change 925124 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] HTMLForm: Allow conditional prefilling even with identifier

https://gerrit.wikimedia.org/r/925124

Change 925125 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SpecialLog: Enable built-in validation of HTMLForm

https://gerrit.wikimedia.org/r/925125

There are page titles with currently invalid character names that were made invalid after pages with those names were created. Does the patch handle that?

There are page titles with currently invalid character names that were made invalid after pages with those names were created. Does the patch handle that?

What's the current behaviour for those titles? The only case that I can think of is the upper-case mapping extended after the upgrade of php, I think we can not query old logs with lower cased titles already.

I documented this as a risky change (at T337528#8933271). I think it's a worthwhile improvement to the code, but there's a chance that some critical patrolling workflow or something relies on the buggy behavior somehow. If we get any bug reports about Special:Log after the deployment, we'll need to revert or figure out how to restore compatibility without undoing the changes.

In the meantime, it'd be nice if someone would put Special:Log through its paces on the beta cluster in the next two weeks. (There's no deployment train next week, the next one is in two weeks.)

Change 925124 merged by jenkins-bot:

[mediawiki/core@master] HTMLForm: Allow conditional prefilling even without identifier

https://gerrit.wikimedia.org/r/925124

Change 925125 merged by jenkins-bot:

[mediawiki/core@master] SpecialLog: Enable built-in validation of HTMLForm

https://gerrit.wikimedia.org/r/925125

Change 930595 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SpecialLog: Fix some interface issues (follow-up to commit 2ac0720)

https://gerrit.wikimedia.org/r/930595

Change 930595 merged by jenkins-bot:

[mediawiki/core@master] SpecialLog: Fix some interface issues (follow-up to commit 2ac0720)

https://gerrit.wikimedia.org/r/930595

Change 934458 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SpecialLog: Fix issues related to IP users

https://gerrit.wikimedia.org/r/934458

Change 934458 merged by jenkins-bot:

[mediawiki/core@master] SpecialLog: Fix issues related to IP users

https://gerrit.wikimedia.org/r/934458

Change 934624 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@wmf/1.41.0-wmf.15] SpecialLog: Fix issues related to IP users

https://gerrit.wikimedia.org/r/934624

Change 934624 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.15] SpecialLog: Fix issues related to IP users

https://gerrit.wikimedia.org/r/934624

Mentioned in SAL (#wikimedia-operations) [2023-07-03T13:19:03Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:934624|SpecialLog: Fix issues related to IP users (T338042 T340929)]]

Mentioned in SAL (#wikimedia-operations) [2023-07-03T13:20:25Z] <urbanecm@deploy1002> func and urbanecm: Backport for [[gerrit:934624|SpecialLog: Fix issues related to IP users (T338042 T340929)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-07-03T13:27:35Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:934624|SpecialLog: Fix issues related to IP users (T338042 T340929)]] (duration: 08m 32s)