Page MenuHomePhabricator
Create Task
Maniphest T338078

eventgate_validation_error - 'mentee_id' should be integer
Closed, ResolvedPublic
Actions

Description

Link to the error - Growth event validation logstash

errored_schema_uri   /analytics/mediawiki/mentor_dashboard/personalized_praise/1.0.2
	
errored_stream_name   mediawiki.mentor_dashboard.personalized_praise
message '.mentee_id' should be integer
meta.domain cs.wikipedia.org
Impact
  • two errors in 24 hours; cswiki and eswiki

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
PersonalizedPraiseLogger: Only include mentee_id if not nullmediawiki/extensions/GrowthExperimentswmf/1.41.0-wmf.12+12 -11
PersonalizedPraiseLogger: Only include mentee_id if not nullmediawiki/extensions/GrowthExperimentswmf/1.41.0-wmf.11+12 -11
PersonalizedPraiseLogger: Only include mentee_id if not nullmediawiki/extensions/GrowthExperimentsmaster+12 -11
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jun 3 2023, 12:38 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 3 2023, 12:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF claimed this task.Jun 4 2023, 7:43 PM
Urbanecm_WMF triaged this task as High priority.
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments-MentorDashboard, GrowthExperiments-PersonalizedPraise; removed Growth-Team.
Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Jun 4 2023, 8:15 PM
gerritbot added a comment.Jun 6 2023, 12:26 PM

Change 927635 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] PersonalizedPraiseLogger: Only include mentee_id if not null

https://gerrit.wikimedia.org/r/927635

gerritbot added a project: Patch-For-Review.Jun 6 2023, 12:26 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 6 2023, 12:27 PM

Affects the notified event. Uploaded a patch to fix this, moving to Code review. Should be backported once merged.

gerritbot added a comment.Jun 6 2023, 4:39 PM

Change 927635 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] PersonalizedPraiseLogger: Only include mentee_id if not null

https://gerrit.wikimedia.org/r/927635

gerritbot added a comment.Jun 6 2023, 5:05 PM

Change 927694 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.12] PersonalizedPraiseLogger: Only include mentee_id if not null

https://gerrit.wikimedia.org/r/927694

gerritbot added a comment.Jun 6 2023, 5:06 PM

Change 927695 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.11] PersonalizedPraiseLogger: Only include mentee_id if not null

https://gerrit.wikimedia.org/r/927695

Urbanecm_WMF mentioned this in T325117: Personalized Praise: Instrumentation.Jun 6 2023, 5:17 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 6 2023, 6:00 PM
gerritbot added a comment.Jun 6 2023, 8:32 PM

Change 927695 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.11] PersonalizedPraiseLogger: Only include mentee_id if not null

https://gerrit.wikimedia.org/r/927695

gerritbot added a comment.Jun 6 2023, 8:33 PM

Change 927694 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.12] PersonalizedPraiseLogger: Only include mentee_id if not null

https://gerrit.wikimedia.org/r/927694

Stashbot added a comment.Jun 6 2023, 8:34 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-06T20:34:02Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:927695|PersonalizedPraiseLogger: Only include mentee_id if not null (T338078)]], [[gerrit:927694|PersonalizedPraiseLogger: Only include mentee_id if not null (T338078)]]

Stashbot added a comment.Jun 6 2023, 8:35 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-06T20:35:37Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:927695|PersonalizedPraiseLogger: Only include mentee_id if not null (T338078)]], [[gerrit:927694|PersonalizedPraiseLogger: Only include mentee_id if not null (T338078)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Jun 6 2023, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-06T20:41:26Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:927695|PersonalizedPraiseLogger: Only include mentee_id if not null (T338078)]], [[gerrit:927694|PersonalizedPraiseLogger: Only include mentee_id if not null (T338078)]] (duration: 07m 23s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.12; 2023-06-06); removed MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 6 2023, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 6 2023, 9:10 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 6 2023, 11:49 PM

This should now be fixed.

Urbanecm_WMF moved this task from In Progress to Ready for QA on the GrowthExperiments-Mentorship board.Jun 6 2023, 11:54 PM
Etonkovidova closed this task as Resolved.Jun 8 2023, 12:33 AM

Checked in betalabs - mentee_id is recorded correctly.

"dt": "2023-06-08T00:29:04Z",
"$schema": "/analytics/mediawiki/mentor_dashboard/personalized_praise/1.0.2",
"database": "enwiki",
"action": "praised",
"action_data": "",
"mentor_id": 6768,
"mentee_id": 11422

No errors in production - the last timestamp: Jun 5, 2023 @ 08:15:41.245

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits