Page MenuHomePhabricator

Adding an undocumented parameter should not require to focus a parameter field input first
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • Open a page containing a template in VisualEditor
  • Open the template in the template editor
  • Try to add an undocumented parameter
    • A] Clicking on the link
    • B] Pressing down the keyboard shortcut Ctrl+Shift+D (Windows/Linux)
    • C] Giving focus to an parameter input field, then pressing down the keyboard shortcut.

What happens?
A] There is no visible link.
B] Pressing down the shortcut does not trigger anything.
C] The link becomes visible, you can click it or press Space to activate it.

What should have happened instead?
A] Maybe the link should be reachable without knowing the keyboard shortcut. But this design question has probably already discussed.
B] The shortcut should work, as it does in C] step.

Other information:
Tested in both Firefox and Chromium.
Should this be a sub-task of T294521?

Event Timeline

Change 927732 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Make "add undocumented parameter" hotkey ctrl+shift+d work much better

https://gerrit.wikimedia.org/r/927732

Change 927732 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Make "add undocumented parameter" hotkey ctrl+shift+d work much better

https://gerrit.wikimedia.org/r/927732

matmarex subscribed.