Page MenuHomePhabricator
Create Task
Maniphest T338124

[maintain-harbor] Errors when parsing tool names
Closed, ResolvedPublic
Actions

Description

It seems we are getting some errors that we should not (I think):

2023-06-05T08:23:46Z - ERROR - tools - Failed to convert tool name ru_monuments to harbor project name. Reason: Tool name ru_monuments is not a valid toolforge tool name.. skipping
2023-06-05T08:23:46Z - ERROR - tools - Failed to convert tool name wdq_checker to harbor project name. Reason: Tool name wdq_checker is not a valid toolforge tool name.. skipping
2023-06-05T08:23:46Z - ERROR - tools - Failed to convert tool name articles-by-lat-lon-without-images to harbor project name. Reason: Tool name articles-by-lat-lon-without-images is not a valid toolforge tool name.. skipping
2023-06-05T08:23:46Z - ERROR - tools - Failed to convert tool name wikidata-redirects-conflicts-reports to harbor project name. Reason: Tool name wikidata-redirects-conflicts-reports is not a valid toolforge tool name.. skipping
2023-06-05T08:27:32Z - ERROR - toolsbeta - Failed to convert tool name toolsbeta.test5 to harbor project name. Reason: Tool name toolsbeta.test5 is not a valid toolforge tool name.. skipping

Those should be valid toolforge tool names, but for some reason it detects them as invalid.

Related Objects
Search...

Event Timeline

dcaro created this task.Jun 5 2023, 9:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2023, 9:36 AM
dcaro added a comment.Jun 5 2023, 9:45 AM

This is probably a bug in the regexes we use to validate the names... regexes are tricky xd

dcaro added a comment.Jun 5 2023, 9:50 AM

The regex is:

TOOLFORGE_NAME_REGEX = re.compile(r"^[a-z]([-a-z0-9]{0,30}[a-z0-9])?$")

Current issues above:

  • ru_monuments -> has _
  • wdq_checker -> has _
  • articles-by-lat-lon-without-images -> >30 chars
  • wikidata-redirects-conflicts-reports -> >30 chars
  • toolsbeta.test5 -> it's not removing the prefix correctly (toolsbeta.)
CodeReviewBot added a comment.Jun 5 2023, 10:33 AM

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/maintain-harbor/-/merge_requests/11

fix tool name splitting

dcaro claimed this task.Jun 5 2023, 10:33 AM
CodeReviewBot added a project: Patch-For-Review.Jun 5 2023, 10:33 AM
dcaro moved this task from Next Up to In Review on the Toolforge Build Service (Iteration 15) board.Jun 5 2023, 10:40 AM
taavi added a subscriber: taavi.Jun 5 2023, 10:46 AM
In T338124#8901726, @dcaro wrote:

Current issues above:

  • ru_monuments -> has _
  • wdq_checker -> has _

These tools don't have Kubernetes namespaces either, we can ignore those. (T176027)

  • articles-by-lat-lon-without-images -> >30 chars
  • wikidata-redirects-conflicts-reports -> >30 chars

Where does the limit of 30 come from?

CodeReviewBot added a comment.Jun 5 2023, 3:32 PM

dcaro updated https://gitlab.wikimedia.org/repos/cloud/toolforge/maintain-harbor/-/merge_requests/11

fix tool name splitting

dcaro added a comment.Jun 5 2023, 3:49 PM
In T338124#8901964, @taavi wrote:
In T338124#8901726, @dcaro wrote:

Current issues above:

  • ru_monuments -> has _
  • wdq_checker -> has _

These tools don't have Kubernetes namespaces either, we can ignore those. (T176027)

  • articles-by-lat-lon-without-images -> >30 chars
  • wikidata-redirects-conflicts-reports -> >30 chars

Where does the limit of 30 come from?

It came from admin.toolforge.org, the form does not allow more than 32 (https://gitlab.wikimedia.org/repos/cloud/toolforge/maintain-harbor/-/merge_requests/11#note_39872)

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2023, 4:10 PM
CodeReviewBot added a comment.Jun 6 2023, 2:29 PM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/maintain-harbor/-/merge_requests/11

fix tool name splitting

KHernandez-WMF moved this task from Iteration 15 to Iteration 16 on the Toolforge Build Service board.Jun 13 2023, 1:40 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 16); removed Toolforge Build Service (Iteration 15).
KHernandez-WMF moved this task from Next Up to In Review on the Toolforge Build Service (Iteration 16) board.
KHernandez-WMF changed the status of subtask T338135: [maintain-harbor] Errors when creating a new project and policy from Open to In Progress.Jun 13 2023, 1:43 PM
dcaro closed this task as Resolved.Jun 21 2023, 7:28 AM
dcaro moved this task from In Review to Done on the Toolforge Build Service (Iteration 16) board.
dcaro moved this task from Done to In Review on the Toolforge Build Service (Iteration 16) board.
dcaro moved this task from In Review to Done on the Toolforge Build Service (Iteration 16) board.
dcaro closed subtask T338135: [maintain-harbor] Errors when creating a new project and policy as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL