| Esanders | |
| Jun 5 2023, 1:21 PM |
| F37132606: Screenshot 2023-07-08 at 00.08.58.png | |
| Jul 7 2023, 11:13 PM |
| F37132604: Screenshot 2023-07-08 at 00.08.20.png | |
| Jul 7 2023, 11:13 PM |
| F37099479: Screenshot 2023-06-09 at 20.44.38.png | |
| Jun 9 2023, 7:53 PM |
| F37099477: Screenshot 2023-06-09 at 20.44.13.png | |
| Jun 9 2023, 7:53 PM |
| F37099471: Screenshot 2023-06-09 at 20.43.57.png | |
| Jun 9 2023, 7:53 PM |
| F37099468: Screenshot 2023-06-09 at 20.43.30.png | |
| Jun 9 2023, 7:53 PM |
| F37094214: image.png | |
| Jun 5 2023, 1:21 PM |
| F37094211: image.png | |
| Jun 5 2023, 1:21 PM |
In full width Vector there usually wasn't room in the viewport for the popups to left align, but now we are fixed width there often is.
We should tell the toolbar to prefer right alignment of popups for right aligned tools.
Observed:
Expected:
Left aligned tools should still have a left aligned popup:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update OOUI to v0.47.3 | mediawiki/core | master | +433 -145 | |
| Match alignment of toolbar popups with the position of the tool | oojs/ui | master | +12 -6 |
Change 927183 had a related patch set uploaded (by Esanders; author: Esanders):
[oojs/ui@master] Match alignment of toolbar popups with the position of the tool
Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/17bd15c7b9/wiki/Douglas Adams?veaction=edit
Also created an OOUI Demos page:
https://patchdemo.wmflabs.org/wikis/17bd15c7b9/w/build/ooui/demos
Change 927183 merged by jenkins-bot:
[oojs/ui@master] Match alignment of toolbar popups with the position of the tool
@Esanders This is still left aligned. Am I missing some testing steps?
Testing on https://en.wikipedia.beta.wmflabs.org/,
Do I need to switch anything on/off?
It's waiting for an OOUI release. Sorry, that's my bad, I didn't look which code repository this change was in.
Change 935793 had a related patch set uploaded (by Catrope; author: Catrope):
[mediawiki/core@master] Update OOUI to v0.47.2
@Esanders This is still left aligned. Am I missing some testing steps?
Testing on https://en.wikipedia.beta.wmflabs.org/,
- open VE
- interract with the toolbar and toggle width
Do I need to switch anything on/off?
✅ toolbar popups are right-aligned for right aligned tools and left-aligned for left-aligned tools
Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted: