Page MenuHomePhabricator

The impact module should display the real numbers instead of capped numbers
Closed, ResolvedPublic

Description

@Msz2001 leave us a message:

The edit counter on the homepage is used also by some of the established editors (as it's easier to discover than the one in preferences). >However, after a recent update of the homepage, the counter was capped at 999 edits, rendering it unusable for experienced editors.

Would it be possible to get the exact number back?

We decided to cap thanks and edits counters to 999+ in T324286: NewImpact: edits and thanks are capped at 1000. We had a limitation (listed at {T324286#8441689}), and the 999+ was acceptable as our targeted audience is newcomers. But it was also up for reconsideration.


Possible technical approach:
We currently use a variable to check for >= 1000 edits, and if so, display this 999+ placeholder. We can't just lift that check, because we only process up to 1,000 edits in our queries when generating user impact data. I think instead we can export the UserEditTracker edit count and override the Impact total edit count with UserEditTracker, if the Impact data's edit count is 1000.

Related task: T341599: Impact Module: improvements for former newcomers


Acceptance Criteria:

Given I'm viewing the new impact module,
Then the Total edits number reflects my edit total across all namespaces.
THERE should no longer need to be a "edit cap" because we are displaying the edit total rather than article edit total.

And for performance reasons and to ensure Impact module queries aren't too costly: the other metrics in the Impact module will only reflect my previous 1,000 edits (across all namespaces)

Given I tap/click on the info icon next to Thanks received,
Then the copy states:

Wikipedia is created by a community of editors like you. You may be thanked by another contributor for an edit you’ve made, and you can thank others for their edits too.
The metric will only include Thanks received for your most recent 1,000 edits.

Given I tap/click on the info icon next to Longest streak,
Then the copy states:

This is the highest number of days in a row that you made at least one edit.
This metric will only reflect editing streaks included in your most recent 1,000 edits.
Your current longest streak is x which you achieved between y – z.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We ended up switching back to showing total edits (as opposed to mainspace edits), didn't we? Total edit count is precomputed, it should be straightforward to display it.

We ended up switching back to showing total edits (as opposed to mainspace edits), didn't we? Total edit count is precomputed, it should be straightforward to display it.

Huh, that was my understanding too. We have definitely switched back to the total edit count, but perhaps that 999+ logic is still in place?

I just checked: https://test.wikipedia.org/wiki/Special:Impact/Pywikibot-test

Screenshot 2023-06-08 at 2.25.21 PM.png (1×814 px, 84 KB)

We have some previous discussion in T324286: NewImpact: edits and thanks are capped at 1000.

We currently use a variable to check for >= 1000 edits, and if so, display this 999+ placeholder. We can't just lift that check, because we only process up to 1,000 edits in our queries when generating user impact data. I think instead we can export the UserEditTracker edit count and override the Impact total edit count with UserEditTracker, if the Impact data's edit count is 1000.

That makes sense. Is this acceptance criteria feasible?

Given I'm viewing the new impact module and I have completed over 1,000 edits,
Then the Total edits number reflects my actual edit total, and
The other metrics in the Impact module will only reflect my previous 1,000 edits (for performance reasons and to ensure Impact module queries aren't too costly).

Wouldn't it be less confusing to always use the total edit count for the edit count card (if we aren't doing it already, I don't remember where we ended up)?

It's worth noting that AFAIK newcomers usually don't have the sense of namespaces. Therefore it may be confusing for them to see the counter going up and down when their articles are moved back and forth between the mainspace and the userspace (sandbox) - some wikis have such process when i.e. a new article doesn't meet basic standards, it is moved to the sandbox.

I think we are all saying the same thing? Either I'm missing something or I phrased that poorly previously. How about:

Given I'm viewing the new impact module,
Then the Total edits number reflects my edit total across all namespaces.
And for performance reasons and to ensure Impact module queries aren't too costly: the other metrics in the Impact module will only reflect my previous 1,000 edits (across all namespaces)

From the last Ambassadors meeting, @Urbanecm_WMF suggests:

we might want to consider adding a notice to the module: "You've made more than 1000 edits, congratulations! Data displayed in this module might not be accurate"

From the last Ambassadors meeting, @Urbanecm_WMF suggests:

we might want to consider adding a notice to the module: "You've made more than 1000 edits, congratulations! Data displayed in this module might not be accurate"

I'm suggesting a revised version of this, since I think editors with more than 1,000 edits won't want to permanently see this as part of the impact module, but I also think it would be nice to "warn" editors about this limitation ahead of time (for an editor who is really working on a long streak for example). So I'm suggesting we just revise the copy of the info popups associated with Thanks received and Longest streak.

@JFernandez-WMF I think this is just waiting for you to review copy and revise if needed. Then please move to Ready for Development. Thanks!

Moving this task to Ready for Development after reviewing and agreeing to copy!

@KStoller-WMF and me discussed this task in our 1:1. My only remaining potential concern is that while we can always get the exact editcount, no matter how high it gets, we have a physically limited space to display it. However, the space we have for the editcount can safely display editcounts that are in the millions area, where only a very few users gets to (on Wikipedias; Wikidata has a different story to tell, but we're not operating there yet) and no users has billions of edits, so we should be good there.

Here is how it would look on desktop:

image.png (1×2 px, 334 KB)

and here is a mobile screenshot

image.png (2×1 px, 324 KB)

On mobile, adding another 999 would make the number a multiline one, but a) that's unlikely to happen as is, based on data and b) even if that happens, it is still perfectly readable.

Since uncapping the editcount and changing a couple of copies is straightforward, I'm being bold and putting this into sprint.

Change 971516 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] UserImpact: Leave total editcount uncapped

https://gerrit.wikimedia.org/r/971516

Change 971516 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] UserImpact: Leave total editcount uncapped

https://gerrit.wikimedia.org/r/971516

Etonkovidova added a subscriber: Etonkovidova.

Checked in beta

Screen Shot 2023-11-08 at 3.16.21 PM.png (1×1 px, 133 KB)

  • the info in messages about 1,000 edits in Thanks received and Longest streak is phrased according to the specs.