Page MenuHomePhabricator

fix-stagging-perms errors out with "find: paths must precede expression: `group'"
Closed, ResolvedPublic

Description

While fixing a permission error on the deployment host earlier today, I noticed the script errors out:

[urbanecm@deploy1002 ~]$ sudo /usr/local/sbin/fix-staging-perms
find: paths must precede expression: `group'

This means the script is unable to change the group owner for /srv/patches. This happens because of a missing dash in the script.

In addition to this, I noticed that the group owner of /srv/patches changed to deployment (this may or may not be the case for /srv/mediawiki-staging before I ran the fixing script and changed it to wikidev). Can someone confirm the group owner for those two paths should still be wikidev?

Event Timeline

Change 927269 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/puppet@production] fix-stagging-perms: Fix group owner change for /srv/patches

https://gerrit.wikimedia.org/r/927269

Change 927269 merged by Dzahn:

[operations/puppet@production] fix-stagging-perms: Fix group owner change for /srv/patches

https://gerrit.wikimedia.org/r/927269

Mentioned in SAL (#wikimedia-operations) [2023-06-05T20:47:54Z] <urbanecm> [urbanecm@deploy1002 ~]$ sudo /usr/local/sbin/fix-staging-perms # verify T338180 fix

deployed in puppet and now:

[deploy1002:~] $ /usr/local/sbin/fix-staging-perms
[deploy1002:~] $
Urbanecm claimed this task.

Change 927584 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/puppet@production] fix-staging-perms: Change group owner to deployment

https://gerrit.wikimedia.org/r/927584

Change 927584 merged by Jcrespo:

[operations/puppet@production] fix-staging-perms: Change group owner to deployment

https://gerrit.wikimedia.org/r/927584