Page MenuHomePhabricator
Create Task
Maniphest T338224

Provide ability to tag GitLab CI built images with a datetime format, set as default in pipeline-to-gitlab conversion
Closed, ResolvedPublic
Actions

Description

Using PipelineLib, we get images tagged with a format like 2023-06-06-094537-production.

The .gitlab-ci.yml that we generate using pipeline-to-gitlab tags images with:

  • latest
  • $CI_COMMIT_TAG
  • $CI_COMMIT_SHA

serviceops would prefer that we continue to use the {year}-{month}-{day}-{timestamp}-production format.

Looking at https://gitlab.com/gitlab-org/gitlab/-/issues/22901, I see that there are variables for CI_PIPELINE_CREATED_AT and CI_JOB_STARTED_AT but their format looks like 2021-03-18T04:45:29Z which is invalid (due to colons) for tagging a Docker image.

Resolution

Use this

variables:
  PUBLISH_IMAGE_TAG: $KOKKURI_PIPELINE_TIMESTAMP-$BUILD_VARIANT

Details

SubjectRepoBranchLines +/-
ipoid: Use date/time image version nameoperations/deployment-chartsmaster+1 -1
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
expand setup.tag to $KOKKURI_PIPELINE_TIMESTAMP-$BUILD_VARIANTrepos/releng/pipeline-to-gitlab!3dancyreview/dancy/setup-tagmaster
Use pipeline timestamp and build variant for default image tagrepos/releng/pipeline-to-gitlab!2kharlankharlan-master-patch-39957master
Define KOKKURI_PIPELINE_TIMESTAMP in KOKKURI_DOTENV_PATHrepos/releng/kokkuri!76dancyreview/dancy/pipeline-timestampmain
Add support for tag templatesrepos/releng/kokkuri!75dancyreview/dancy/tags-date-templatemain
gitlab: Use date format for tagged imagesrepos/mediawiki/services/ipoid!5kharlangitlab-use-datemain
Customize query in GitLab

Related Objects
Search...

Event Timeline

kostajh created this task.Jun 6 2023, 11:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2023, 11:15 AM
Joe subscribed.EditedJun 6 2023, 11:24 AM

Specifically, what we want is:

  • that image tags are obviously sortable in chronological order.
  • that the tagging format is consistent across all repositories and all images

I would consider this as a blocker to get images built in gitlab running in the wikikube cluster.

Jelto subscribed.Jun 6 2023, 11:25 AM
CodeReviewBot added a comment.Jun 6 2023, 11:32 AM

kharlan opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/5

gitlab: Use date format for tagged images

CodeReviewBot added a project: Patch-For-Review.Jun 6 2023, 11:32 AM
kostajh added a comment.Jun 6 2023, 11:46 AM

I think we could do something like export CI_IMAGE_PUBLISH_DATE=$(date +"%Y-%m-%d-%H%M%S"-$BUILD_VARIANT) in https://gitlab.wikimedia.org/repos/releng/kokkuri/-/blob/main/includes/images.yaml#L90.

thcipriani edited projects, added Release-Engineering-Team (They Live 🕶️🧟); removed Release-Engineering-Team.Jun 6 2023, 3:53 PM
thcipriani moved this task from Backlog to Ready on the Release-Engineering-Team (They Live 🕶️🧟) board.
dancy subscribed.Jun 6 2023, 3:57 PM
kostajh mentioned this in T337714: Migrate mediawiki/services/ipoid to GitLab.Jun 9 2023, 10:18 AM
jeena moved this task from Ready to Waiting for review on the Release-Engineering-Team (They Live 🕶️🧟) board.Jun 12 2023, 9:02 PM
brennen moved this task from Inbox to CI & Job Runners on the GitLab board.Jun 15 2023, 5:00 PM
brennen edited projects, added GitLab (CI & Job Runners); removed GitLab.
CodeReviewBot added a comment.Jun 15 2023, 10:22 PM

dancy updated https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/75

Add support for tag templates

dancy changed the task status from Open to In Progress.Jun 15 2023, 10:27 PM
dancy claimed this task.
dancy triaged this task as Medium priority.
CodeReviewBot added a comment.Jun 21 2023, 8:26 PM

dancy closed https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/75

Add support for tag templates

CodeReviewBot added a comment.Jun 21 2023, 8:42 PM

dancy opened https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/76

Define KOKKURI_PIPELINE_TIMESTAMP in KOKKURI_DOTENV_PATH

CodeReviewBot added a comment.Jun 21 2023, 8:51 PM

kharlan closed https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/5

gitlab: Use date format for tagged images

CodeReviewBot added a comment.Jun 23 2023, 2:45 PM

dancy merged https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/76

Define KOKKURI_PIPELINE_TIMESTAMP in KOKKURI_DOTENV_PATH

dancy added a comment.EditedJun 23 2023, 2:49 PM

You can use something like this now:

variables:
  PUBLISH_IMAGE_TAG: $KOKKURI_PIPELINE_TIMESTAMP-$BUILD_VARIANT
CodeReviewBot added a comment.Jun 26 2023, 8:40 AM

kharlan reopened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/5

gitlab: Use date format for tagged images

CodeReviewBot added a comment.Jun 26 2023, 12:34 PM

tchanders merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/5

gitlab: Use date format for tagged images

gerritbot added a comment.Jun 26 2023, 1:17 PM

Change 933096 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/deployment-charts@master] ipoid: Use date/time image version name

https://gerrit.wikimedia.org/r/933096

dancy closed this task as Resolved.Jun 26 2023, 2:57 PM
dancy updated the task description. (Show Details)
CodeReviewBot added a comment.Jun 26 2023, 3:04 PM

kharlan opened https://gitlab.wikimedia.org/repos/releng/pipeline-to-gitlab/-/merge_requests/2

Use pipeline timestamp and build variant for default image tag

CodeReviewBot added a comment.Jun 26 2023, 4:03 PM

dancy updated https://gitlab.wikimedia.org/repos/releng/pipeline-to-gitlab/-/merge_requests/3

expand setup.tag to $KOKKURI_PIPELINE_TIMESTAMP-$BUILD_VARIANT

CodeReviewBot added a comment.Jun 26 2023, 4:06 PM

dancy merged https://gitlab.wikimedia.org/repos/releng/pipeline-to-gitlab/-/merge_requests/3

expand setup.tag to $KOKKURI_PIPELINE_TIMESTAMP-$BUILD_VARIANT

CodeReviewBot added a comment.Jun 26 2023, 4:06 PM

dancy closed https://gitlab.wikimedia.org/repos/releng/pipeline-to-gitlab/-/merge_requests/2

Use pipeline timestamp and build variant for default image tag

gerritbot added a comment.Jun 30 2023, 11:56 AM

Change 933096 merged by jenkins-bot:

[operations/deployment-charts@master] ipoid: Use date/time image version name

https://gerrit.wikimedia.org/r/933096

Jelto mentioned this in T340182: move micro tendril.wikimedia.org and dbtree.wikimedia.org to kubernetes.Jul 6 2023, 9:47 AM
dancy moved this task from Waiting for review to Done on the Release-Engineering-Team (They Live 🕶️🧟) board.Jul 26 2023, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL