Page MenuHomePhabricator

Temporary Accounts on Android: Editing
Open, LowPublic

Assigned To
None
Authored By
cmadeo
Jun 6 2023, 7:18 PM
Referenced Files
F57465609: IMG_4671.jpg
Sep 5 2024, 9:02 PM
F37029374: IP Masking icon - proposed v1 (2).svg
Jun 6 2023, 7:18 PM
File Not Attached
F37029372: image.png
Jun 6 2023, 7:18 PM
File Not Attached
F37095755: Vector.svg
Jun 6 2023, 7:18 PM
F37095752: image.png
Jun 6 2023, 7:18 PM
F37095751: image.png
Jun 6 2023, 7:18 PM
F37095750: image.png
Jun 6 2023, 7:18 PM
F37095748: image.png
Jun 6 2023, 7:18 PM

Description

Summary of updates

Outlined below are proposed updates to the Android editing flow for unregistered editors with and without temporary accounts. These updates were made to reflect proposed changes on desktop web related to IP masking work. Text in the screens below comes from proposed strings in the IP masking deck from AHT and may be subject to change.

Relevant links

Proposed designs

Unregistered edits for users without temporary accounts
Editor - First unregistered editEditor with edit notice - First unregistered editFirst unregistered edit - tap on account iconFirst unregistered edit - edit summary screenAfter publishing and a new temp account is created 1/2After publishing and a new temp account is created 2/2
image.png (1×720 px, 209 KB)
image.png (1×720 px, 296 KB)
image.png (1×720 px, 211 KB)
image.png (1×720 px, 140 KB)
image.png (1×720 px, 290 KB)
image.png (1×720 px, 285 KB)
Shown on first unregistered edit once in the editorShown on first unregistered edit once in the editor for an article with an edit noticeShown when tapping on the account icon in the header. Learn more link to be provided by AHT in the futureShown on edit summary screenRegular publish confirmationShown after publishing only when a temp account is created based on the publish action
Unregistered edits for users with temporary accounts
Editor with edit notice - subsequent unregistered editsSubsequent unregistered edits - tap on account iconSubsequent unregistered edits - edit summary screenEdit published
image.png (1×720 px, 295 KB)
image.png (1×720 px, 196 KB)
image.png (1×720 px, 135 KB)
image.png (1×720 px, 293 KB)
Shown to users editing with a temporary account for an article with an edit noticeShown when tapping on the account icon in the header. IP address link to be provided by AHT in the futureShown on edit summary screenNormal publish confirmation shown
Assets
Unregistered edit without temp account icons
Material design icon: No Account
IP masking temp account icon
image.png (220×220 px, 4 KB)
from https://phabricator.wikimedia.org/T335694

Event Timeline

LGoto triaged this task as Low priority.Jun 13 2023, 6:14 PM
LGoto removed a project: Wikipedia-iOS-App-Backlog.
HNordeenWMF renamed this task from IP Masking on Android: Editing to Temporary Accounts on Android: Editing.Apr 2 2024, 4:04 PM

Apologies for the photo / eInk device, but it's what I've got...

Editor - First unregistered edit

IMG_4671.jpg (4×3 px, 2 MB)

  • Is it possible to use the strings as outlined in the ticket above? (eg. Got it, Create account for first view and Discard changes and log in, Got it once change have been made in the editor)
  • After publishing an edit I saw the edit confirmation but not the temp account created confirmation toast (1st attempt) and on 2nd attempt (ended session and then edited again) I saw the temp account created toast but not the edit published toast.

*The icon changed from no account to temp account while on the edit summary page

Editor - Subsequent edits
  • Would it be possible to show the 'The page has been modified. Are you sure you want to exit without saving your changes' alert when a user taps on 'log-in' from the temp account / no account dialog?

@Dbrant I've updated the comment above to reflect usage on Test wiki. Thank you!

cmadeo removed cmadeo as the assignee of this task.Sep 6 2024, 8:45 PM

(latest apk: https://github.com/wikimedia/apps-android-wikipedia/actions/runs/10778565666)

  • Is it possible to use the strings as outlined in the ticket above? (eg. Got it, Create account for first view and Discard changes and log in, Got it once change have been made in the editor)

Sure, but I'm curious why we're insisting that the changes will be discarded? The login workflow will take the user back to editing, with their changes intact. Can we just say "Log in" instead of "Discard changes and log in"?

  • After publishing an edit I saw the edit confirmation but not the temp account created confirmation toast (1st attempt) and on 2nd attempt (ended session and then edited again) I saw the temp account created toast but not the edit published toast.

Should be correct now. (It looks like there were some minor updates to the designs since I last worked on it.)

*The icon changed from no account to temp account while on the edit summary page

Should be correct now.

  • Would it be possible to show the 'The page has been modified. Are you sure you want to exit without saving your changes' alert when a user taps on 'log-in' from the temp account / no account dialog?

As mentioned above, going to Log In does not actually "exit" the editing workflow, so do we really need to show such a message?

Sure, but I'm curious why we're insisting that the changes will be discarded? The login workflow will take the user back to editing, with their changes intact. Can we just say "Log in" instead of "Discard changes and log in"?

@Dbrant thanks for your clarifications -- I didn't realize that changes won't be discarded so happy to have it say 'log in' as it does now.

Should be correct now. (It looks like there were some minor updates to the designs since I last worked on it.)

Fantastic, I saw it appear this time.