Page MenuHomePhabricator
Create Task
Maniphest T338450

Update StructuredDiscussions (Flow) to use the new HookContainer/HookRunner system
Open, Needs TriagePublic
Actions

Description

Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md for documentation.

  • Create HookRunner class and the hook handler interfaces
  • Use hook handlers

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move some Echo hook handler to new class to make Echo optionalmediawiki/extensions/FlowREL1_43+82 -64
Move some Echo hook handler to new class to make Echo optionalmediawiki/extensions/FlowREL1_44+82 -64
Move some Echo hook handler to new class to make Echo optionalmediawiki/extensions/Flowmaster+82 -64
Use HookHandlers for Echo hooksmediawiki/extensions/Flowmaster+44 -39
Use HookHandlers for core hooksmediawiki/extensions/Flowmaster+340 -194
Create HookRunner class and the hook handler interfacesmediawiki/extensions/Flowmaster+180 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Jun 8 2023, 12:21 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 8 2023, 12:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system.Jun 8 2023, 12:21 PM
gerritbot added a comment.Jun 8 2023, 12:22 PM

Change 927792 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] Create HookRunner class and the hook handler interfaces

https://gerrit.wikimedia.org/r/927792

gerritbot added a project: Patch-For-Review.Jun 8 2023, 12:22 PM
• Tgr moved this task from Inbox to Triaged on the Growth-Team board.Jun 8 2023, 9:19 PM
• Tgr subscribed.Jun 8 2023, 9:25 PM

IMO not worth the effort. See T332022: [Epic] Undeploying StructuredDiscussions (Flow).

Umherirrender added a project: Core Platform Team Initiatives (New Hook System).Jun 9 2023, 8:39 PM
gerritbot added a comment.Aug 6 2023, 11:57 AM

Change 927792 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Create HookRunner class and the hook handler interfaces

https://gerrit.wikimedia.org/r/927792

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 6 2023, 12:00 PM
Umherirrender removed a project: Patch-For-Review.Aug 6 2023, 12:01 PM
Umherirrender updated the task description. (Show Details)
Umherirrender updated the task description. (Show Details)Sep 16 2023, 10:16 PM
Umherirrender mentioned this in T346523: Update WikimediaMessages to use the new HookContainer/HookRunner system.Sep 16 2023, 11:36 PM
Umherirrender claimed this task.Sep 30 2023, 11:15 PM
gerritbot added a comment.Sep 30 2023, 11:23 PM

Change 962150 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] Use HookHandlers for core hooks

https://gerrit.wikimedia.org/r/962150

gerritbot added a project: Patch-For-Review.Sep 30 2023, 11:23 PM
gerritbot added a comment.Oct 1 2023, 3:40 PM

Change 962150 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Use HookHandlers for core hooks

https://gerrit.wikimedia.org/r/962150

Umherirrender removed Umherirrender as the assignee of this task.Oct 1 2023, 3:54 PM
Umherirrender removed a project: Patch-For-Review.
Umherirrender updated the task description. (Show Details)
Umherirrender unsubscribed.Sep 3 2024, 7:58 PM
gerritbot added a comment.Sep 15 2024, 6:34 PM

Change #1072914 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] Use HookHandlers for Echo hooks

https://gerrit.wikimedia.org/r/1072914

gerritbot added a project: Patch-For-Review.Sep 15 2024, 6:34 PM
gerritbot added a comment.Oct 8 2024, 6:55 PM

Change #1072914 abandoned by Umherirrender:

[mediawiki/extensions/Flow@master] Use HookHandlers for Echo hooks

Reason:

T332022

https://gerrit.wikimedia.org/r/1072914

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2024, 7:31 PM
gerritbot added a comment.Oct 11 2025, 9:53 PM

Change #1195388 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] Move some Echo hook handler to new class to make Echo optional

https://gerrit.wikimedia.org/r/1195388

gerritbot added a project: Patch-For-Review.Oct 11 2025, 9:53 PM
gerritbot added a comment.Oct 11 2025, 10:51 PM

Change #1195388 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Move some Echo hook handler to new class to make Echo optional

https://gerrit.wikimedia.org/r/1195388

Maintenance_bot removed a project: Patch-For-Review.Oct 11 2025, 11:30 PM
gerritbot added a comment.Oct 12 2025, 11:01 AM

Change #1195401 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@REL1_44] Move some Echo hook handler to new class to make Echo optional

https://gerrit.wikimedia.org/r/1195401

gerritbot added a project: Patch-For-Review.Oct 12 2025, 11:01 AM
gerritbot added a comment.Oct 12 2025, 11:29 AM

Change #1195401 merged by jenkins-bot:

[mediawiki/extensions/Flow@REL1_44] Move some Echo hook handler to new class to make Echo optional

https://gerrit.wikimedia.org/r/1195401

gerritbot added a comment.Oct 12 2025, 11:30 AM

Change #1195403 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@REL1_43] Move some Echo hook handler to new class to make Echo optional

https://gerrit.wikimedia.org/r/1195403

gerritbot added a comment.Oct 12 2025, 12:04 PM

Change #1195403 merged by jenkins-bot:

[mediawiki/extensions/Flow@REL1_43] Move some Echo hook handler to new class to make Echo optional

https://gerrit.wikimedia.org/r/1195403

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2025, 12:30 PM
Urbanecm_WMF removed a project: Growth-Team.Oct 28 2025, 12:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits