Page MenuHomePhabricator

[toolforge] Replace interpose with a maintained library
Closed, ResolvedPublic

Description

The toolforge-envvars-api project is using the interpose Go library, that hasn't been updated in 6 years. I think we should replace it with a maintained library, or write our own middleware.

The library is currently referenced in the official go-swagger docs, so I opened an upstream bug as well: https://github.com/go-swagger/go-swagger/issues/2948

Event Timeline

Turns out that this is bigger than I expected, the go-swagger maintainer said they are there's not going to be an effort to upgrade to openapi 3 (see https://github.com/go-swagger/go-swagger/issues/1122). So I decided to move to another very well maintained generator (currently), more generic though, so a bit less strict with type checking.

As a side effect, this removes a bunch of lines of code xd