Page MenuHomePhabricator

Join tracking table list and detail view of donations
Open, Needs TriagePublic

Description

Both list and detail view use the class DatabaseDonationQueries to query the database via the ORM.

The smallest change here would be as follows:

  • change the deprecated DoctrineORMDonationRepository queries to join the Tracking entity (with an eager fetch to avoid the 1+N query problem)
  • add a tracking key in DatabaseDonationQueries::createRowFromDoctrineDonation that uses the Tracking entity
  • Remove tracking from DatabaseDonationQueries::getLegacyData

A better approach would be to replace the DoctrineORMDonationRepository dependency and use Doctrine DBAL directly.