Page MenuHomePhabricator

Search Preview: MultiMediaViewer MMV stopped working on Mobile
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Access the search page on mobile
  • Open a search result clicking on the snippet
  • Scroll right to see "commons images"
  • click on one of the image

What happens?:

  • Nothing happens

What should have happened instead?:

  • The Multimedia viewer should have opened up

Other information (browser name/version, screenshots, etc.):

  • The issue is triggered by this change in MinervaNeue: 2179d08a8edd903d292ec20b3de31cf53059d7aa
  • The click event in Vue does not bubble all the way to the main content and therefore it is not detected
  • This could be a problem for any app preventing the "a" tag from redirecting (using preventDefault() )

Event Timeline

Change 928781 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Search Preview: MultiMediaViewer MMV stopped working on Mobile

https://gerrit.wikimedia.org/r/928781

Aklapper added a project: SDAW-SearchVue.

Please add code base project tags, so other people who don't know or don't care about team tags can also find this task when searching via projects. Thanks!

Change 928781 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Search Preview: MultiMediaViewer MMV stopped working on Mobile

https://gerrit.wikimedia.org/r/928781

Etonkovidova subscribed.

Checked in betalabs and wmf.15 - the fix is in place: clicking on Related images will display them in Multimedia Viewer.

Screen Shot 2023-06-22 at 7.47.05 PM.png (1×770 px, 1 MB)