Show IP: Handle API errors on Special:Block
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jun 9 2023, 2:31 PM

Description

What is the problem?

If I use the Show IP feature on Special:Block, and the API returns an error, the Show IP area is blank.

We could probably handle it more gracefully. For example, by showing an error.

Similar to the work done in T333190.

Steps to reproduce problem

Login to the wiki on one browser
Go to Special:Block
On another browser, login to the same wiki as another user and block the user you logged in as in step 1
Go back to the first browser, on Special:Block, and enter a valid temporary user into the username field
Click "Show IP"

Expected behavior: Because the user is now blocked, there should be some sort of error.
Observed behavior: Nothing is shown, the output is blank.

Details

	Subject	Repo	Branch	Lines +/-
	Show IP: Handle API errors on Special:Block	mediawiki/extensions/CheckUser	master	+6 -0

Customize query in gerrit

Related Objects

Mentioned In: T333190: What should happen if clicking on an IP reveal button results in an API error?
Mentioned Here: T338154: IP Masking: Special:Block- ShowIP appears when "*" only has been entered
T333190: What should happen if clicking on an IP reveal button results in an API error?

Event Timeline

dom_walden created this task.Jun 9 2023, 2:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2023, 2:31 PM

dom_walden mentioned this in T333190: What should happen if clicking on an IP reveal button results in an API error?.Jun 9 2023, 2:32 PM

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 31 - The Fez); removed Anti-Harassment.Jun 9 2023, 3:12 PM

This seems worth prioritising, also given T338154: IP Masking: Special:Block- ShowIP appears when "*" only has been entered.

Just adding this here in case the patch for this task doesn't fix this which was also mentioned from https://phabricator.wikimedia.org/T333190#8907984

On the username invalid screenshot, I deleted *Unregistered 31. When I was checking out various pages to see if it has the same outcome, it has except on Special:Block. All the other pages it shows deleted but on Special:Block it still shows the IP address of the deleted user

• TThoabala claimed this task.Jun 12 2023, 5:22 AM

• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 12 2023, 11:16 AM

Change 929373 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/CheckUser@master] Show IP: Handle API errors on Special:Block

https://gerrit.wikimedia.org/r/929373

gerritbot added a project: Patch-For-Review.Jun 12 2023, 3:27 PM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 12 2023, 3:37 PM

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 13 2023, 1:56 PM

Change 929373 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Show IP: Handle API errors on Special:Block

https://gerrit.wikimedia.org/r/929373

Maintenance_bot removed a project: Patch-For-Review.Jun 13 2023, 2:29 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 13 2023, 3:00 PM

@TThoabala It's showing "error" when the other user is blocked on another browser as seen from the screenshots below. As for https://phabricator.wikimedia.org/T338620#8919434, if it's fine for the Admin to still see the IP addresses when the User/IP is deleted, then we can move this to Done. Non-Admin does not see any IP addresses when the User/IP is deleted. Thanks!

OS: Safari 13.3
Browsers: Safari 16.4, Chrome 114

Before Testuserone was Blocked -IP address is shown

T338620_IPMasking_ShowIP_SpecialBlockError.png (1×3 px, 589 KB)

After Testuserone was Blocked- Displays "(error)"

T338620_IPMasking_ShowIP_SpecialBlockErrorAfter.png (1×3 px, 476 KB)

Base off https://phabricator.wikimedia.org/T338620#8919434. Admin can still see IP address even when the user/IP is deleted. Non-Admin doesn't see anything.

User Deleted	Admin Special:Contributions	Admin Special:Block	Non-AdminSpecial:Contributions

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 31 - The Fez) board.Jun 13 2023, 11:07 PM

Tchanders closed this task as Resolved.Aug 14 2023, 10:09 AM

	F37102883: T338620_IPMasking_ShowIP_UserDeleted_NonAdminContribution.png
	Jun 13 2023, 11:07 PM

	F37102881: T338620_IPMasking_ShowIP_UserDeleted_AdminSpecialBlock.png
	Jun 13 2023, 11:07 PM

	F37102879: T338620_IPMasking_ShowIP_UserDeleted_AdminContribution.png
	Jun 13 2023, 11:07 PM

	F37102877: T338620_IPMasking_ShowIP_UserDeleted.png
	Jun 13 2023, 11:07 PM

	F37102873: T338620_IPMasking_ShowIP_SpecialBlockErrorAfter.png
	Jun 13 2023, 11:07 PM

	F37102871: T338620_IPMasking_ShowIP_SpecialBlockError.png
	Jun 13 2023, 11:07 PM

	F37095908: T333190_IPMasking_IPReveal_DeletedSpecialBlock.png
	Jun 9 2023, 7:59 PM

Show IP: Handle API errors on Special:BlockClosed, ResolvedPublicBUG REPORTActions