Page MenuHomePhabricator
Create Task
Maniphest T338622

Can't remove an empty linebreak between two tables
Closed, ResolvedPublic
Actions

Description

  • Create a document:
TABLE
empty paragraph
TABLE
  • Place your cursor in the empty paragraph
  • Press delete or backspace

Expected
The table paragraph before/after is deleted

Observed
The table before/after is selected

The same happens if you replace the tables with other block elements, e.g. block images.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (e2cf1e114)mediawiki/extensions/VisualEditormaster+1 -1
Delete empty paragraphs when next to block nodesVisualEditor/VisualEditormaster+24 -11
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jun 9 2023, 2:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2023, 2:58 PM
Esanders added a project: VisualEditor-ContentEditable.Jun 9 2023, 3:55 PM
gerritbot added a comment.Jun 9 2023, 5:03 PM

Change 928882 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Delete empty paragraphs when next to block nodes

https://gerrit.wikimedia.org/r/928882

gerritbot added a project: Patch-For-Review.Jun 9 2023, 5:03 PM
Esanders added a project: Editing-team (Kanban Board).Jun 9 2023, 5:04 PM
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 14 2023, 9:01 PM
matmarex subscribed.
gerritbot added a comment.Jun 14 2023, 9:04 PM

Change 928882 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Delete empty paragraphs when next to block nodes

https://gerrit.wikimedia.org/r/928882

Maintenance_bot removed a project: Patch-For-Review.Jun 14 2023, 9:10 PM
gerritbot added a comment.Jun 14 2023, 9:10 PM

Change 930260 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e2cf1e114)

https://gerrit.wikimedia.org/r/930260

gerritbot added a project: Patch-For-Review.Jun 14 2023, 9:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jun 14 2023, 9:12 PM
matmarex added a project: Editing QA.
gerritbot added a comment.Jun 14 2023, 9:49 PM

Change 930260 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e2cf1e114)

https://gerrit.wikimedia.org/r/930260

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 14 2023, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 14 2023, 10:10 PM
Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Jul 6 2023, 6:18 PM
Ryasmeen removed a project: Editing QA.
Ryasmeen subscribed.

This is still happening. Pressing backspace/delete when the cursor is in the empty paragraph selects the previous table, doesn't delete it.

• ppelberg moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Jul 17 2023, 5:09 PM
Esanders added a comment.Jul 18 2023, 12:11 PM

Works for me. The vertical space of the paragraph doesn't disappear because it gets replaced by a "block slug", which you can click to re-insert the paragraph:
Before:

image.png (320×162 px, 1 KB)

After backspacing:

image.png (329×508 px, 7 KB)

...then moving the selection
image.png (329×508 px, 6 KB)

• ppelberg assigned this task to Ryasmeen.Aug 1 2023, 4:59 PM
• ppelberg moved this task from Ready to Be Worked On to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
• ppelberg added a project: Editing QA.Sep 11 2023, 5:19 PM
• ppelberg subscribed.Oct 23 2023, 5:10 PM
In T338622#8995373, @Ryasmeen wrote:

This is still happening. Pressing backspace/delete when the cursor is in the empty paragraph selects the previous table, doesn't delete it.

@Ryasmeen: are you able to share a screen recording of what you're seeing?

...it appears @Esanders has not yet been able to reproduce the issue you encountered.

Ryasmeen moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 23 2023, 11:20 PM
In T338622#9273610, @ppelberg wrote:
In T338622#8995373, @Ryasmeen wrote:

This is still happening. Pressing backspace/delete when the cursor is in the empty paragraph selects the previous table, doesn't delete it.

@Ryasmeen: are you able to share a screen recording of what you're seeing?

...it appears @Esanders has not yet been able to reproduce the issue you encountered.

@ppelberg /@Esanders: The task description says expected result is, the table before/after should be "deleted" instead of getting selected. It is right now getting selected as @Esanders mentioned.

Esanders updated the task description. (Show Details)Oct 24 2023, 5:29 PM
Esanders added a comment.Oct 24 2023, 5:32 PM
In T338622#9274616, @Ryasmeen wrote:

@ppelberg /@Esanders: The task description says expected result is, the table before/after should be "deleted" instead of getting selected. It is right now getting selected as @Esanders mentioned.

Apologies, the expected case should've said "paragraph"!

Ryasmeen added a project: Verified.Nov 2 2023, 12:29 AM
Ryasmeen removed a project: Editing QA.Nov 5 2023, 12:34 AM
VPuffetMichel closed this task as Resolved.Dec 4 2023, 6:54 PM
Esanders merged a task: T119516: Backspace in an empty paragraph after a template / table selects it but doesn't remove the paragraph.Dec 7 2023, 3:52 PM
Esanders added subscribers: DLynch, Vojtech.dostal, nshahquinn-wmf, StudiesWorld.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL