Page MenuHomePhabricator
Create Task
Maniphest T338793

Condense AdvancedSearch browser tests suite
Closed, ResolvedPublic
Actions

Description

The test suite is pretty big and we should try to narrow it down a bit. Similar to T282935: Clean-up slow TwoColConflict browser tests suite some tests can probably be merged or left out.

  • Try merging tests so that they're testing the workflow with assertions in between.
  • Try removing tests when the aspect tested there can be tested differently on a lower level.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use waitForExist correctlymediawiki/extensions/AdvancedSearchmaster+4 -2
Minor cleanups in the browser testsmediawiki/extensions/AdvancedSearchmaster+7 -27
Merge and reduce selenium tests in namespaces specmediawiki/extensions/AdvancedSearchmaster+19 -54
Merge and reduce selenium tests in defaultNamespaces specmediawiki/extensions/AdvancedSearchmaster+2 -18
Merge and reduce selenium tests in searchsubmit specmediawiki/extensions/AdvancedSearchmaster+42 -71
Merge and reduce selenium tests in searchpage specmediawiki/extensions/AdvancedSearchmaster+22 -71
Merge and reduce selenium tests in advancedsearch specmediawiki/extensions/AdvancedSearchmaster+48 -110
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Jun 12 2023, 1:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2023, 1:55 PM
WMDE-Fisch moved this task from Backlog to Doing on the WMDE-TechWish-Maintenance-2023 board.Jun 12 2023, 1:55 PM
WMDE-Fisch added a parent task: T300791: Refactor AdvancedSearch WebdriverIO tests from sync to async mode.
WMDE-Fisch updated the task description. (Show Details)Jun 13 2023, 8:39 AM
gerritbot added a comment.Jun 13 2023, 6:31 PM

Change 929775 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in advancedsearch spec

https://gerrit.wikimedia.org/r/929775

gerritbot added a project: Patch-For-Review.Jun 13 2023, 6:31 PM
gerritbot added a comment.Jun 14 2023, 6:04 AM

Change 929942 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in namespaces spec

https://gerrit.wikimedia.org/r/929942

gerritbot added a comment.Jun 14 2023, 6:11 AM

Change 929943 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in searchsubmit spec

https://gerrit.wikimedia.org/r/929943

gerritbot added a comment.Jun 14 2023, 7:00 AM

Change 929954 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in searchpage spec

https://gerrit.wikimedia.org/r/929954

WMDE-Fisch merged a task: T301237: Streamline AdvancedSearch selenium tests.Jun 14 2023, 8:31 AM
WMDE-Fisch added a parent task: T282219: Investigate skipped tests in AdvancedSearch selenium daily.
Tobi_WMDE_SW subscribed.Jun 14 2023, 11:35 AM
gerritbot added a comment.Jun 16 2023, 1:15 PM

Change 929775 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in advancedsearch spec

https://gerrit.wikimedia.org/r/929775

gerritbot added a comment.Jun 16 2023, 1:15 PM

Change 929943 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in searchsubmit spec

https://gerrit.wikimedia.org/r/929943

gerritbot added a comment.Jun 16 2023, 1:19 PM

Change 929954 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in searchpage spec

https://gerrit.wikimedia.org/r/929954

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 16 2023, 2:00 PM
thiemowmde subscribed.Jun 16 2023, 2:31 PM

These are totally unreliable numbers. But when I compare a CI selenium run from before and after these patches the runtime goes down from 1:51 to 1:15.

gerritbot added a comment.Jun 16 2023, 2:36 PM

Change 929942 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in defaultNamespaces spec

https://gerrit.wikimedia.org/r/929942

Maintenance_bot removed a project: Patch-For-Review.Jun 16 2023, 3:10 PM
gerritbot added a comment.Jun 19 2023, 7:16 AM

Change 931054 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in namespaces spec

https://gerrit.wikimedia.org/r/931054

gerritbot added a project: Patch-For-Review.Jun 19 2023, 7:16 AM
gerritbot added a comment.Jun 19 2023, 7:24 AM

Change 931061 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/AdvancedSearch@master] Minor cleanups in the browser tests

https://gerrit.wikimedia.org/r/931061

WMDE-Fisch moved this task from Doing to Review on the WMDE-TechWish-Maintenance-2023 board.Jun 19 2023, 7:30 AM
gerritbot added a comment.Jun 21 2023, 1:14 PM

Change 931054 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Merge and reduce selenium tests in namespaces spec

https://gerrit.wikimedia.org/r/931054

gerritbot added a comment.Jun 21 2023, 1:14 PM

Change 931061 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Minor cleanups in the browser tests

https://gerrit.wikimedia.org/r/931061

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2023, 1:30 PM
WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Jun 22 2023, 7:43 PM
WMDE-Fisch moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.
WMDE-Fisch closed this task as Resolved.Jun 28 2023, 9:09 AM
gerritbot added a comment.Mar 31 2025, 6:31 AM

Change #1132407 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] Use waitForExist correctly

https://gerrit.wikimedia.org/r/1132407

gerritbot added a project: Patch-For-Review.Mar 31 2025, 6:31 AM
gerritbot added a comment.Apr 1 2025, 5:55 AM

Change #1132407 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Use waitForExist correctly

https://gerrit.wikimedia.org/r/1132407

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2025, 6:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits